Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monaco 0.47 #15666

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Monaco 0.47 #15666

wants to merge 1 commit into from

Conversation

@Piedone
Copy link
Member

Piedone commented Apr 5, 2024

Did you test it with the built-in Monaco-using editors?

@agriffard
Copy link
Member Author

Did you test it with the built-in Monaco-using editors?

Yes, tested with Text Field, Html Body Part and Templates (intellisense on Liquid filters).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this under the Templates editor:

2024-04-06_13h00_37.mp4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce this behaviour.
If someone else can confirm, please do.

@MikeAlhayek
Copy link
Member

@agriffard is this something ready to merge?

@Piedone
Copy link
Member

Piedone commented May 3, 2024

No, see above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants