Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure Communication SMS #15539

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Support Azure Communication SMS #15539

wants to merge 4 commits into from

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Mar 18, 2024

This is still WIP

@MikeAlhayek
Copy link
Member

Way too many files changes here. It seems that you copied all the SMS files into a new module. All you should need to do

  1. Create OC.Sms.Azure module project
  2. Implement the ISmsProvider and register it as described here https://docs.orchardcore.net/en/latest/docs/reference/modules/Sms/
  3. You may want to add a provider for configuration provider using DefaultAzure key and another for Settings Azure. This way user can use a saas environment provider "if available" or they can enable one by providing their custom Azure instance settings like we did in the SMTP and Azure Email providers.

@hishamco
Copy link
Member Author

As I said it's WIP, I'm working on it :)

@agriffard agriffard changed the title Suuport Azure Communication SMS Support Azure Communication SMS Mar 19, 2024
Copy link

github-actions bot commented Apr 7, 2024

This pull request has merge conflicts. Please resolve those before requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants