Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFs config.yaml as a independent file #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fhgrings
Copy link

Desagragated NFs config files from values.yaml to easiest manipulation when working with multiple slices and deployments

  • Created a config.yaml file for each function that requires it
  • Removed configuration.configuration value from values.yaml
  • Replaced config-map.yaml to read a file

@raoufkh
Copy link
Collaborator

raoufkh commented Dec 7, 2023

Thank you @fhgrings for this suggestion. However, the idea behind putting the conf in the values.yaml file is to avoid hardcoding and make helm charts more easily reusable. With Helm, it's possible to reuse exactly the same Helm chart for several possible scenarios by customizing only the values file and not touching any other element in the Helm chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants