Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/url tagging #17

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Feat/url tagging #17

wants to merge 17 commits into from

Conversation

ptbarnum4
Copy link

@ptbarnum4 ptbarnum4 commented Aug 26, 2023

WIP: Initial idea for url tagging

  • Accepts optional tag in URL
    • /:code/:tag?

examples

Resolve the second param as tag code

TODO:

  • Create Tags collection
  • Add a "tag" when we want to correlate user to link (where and how I'm not sure, maybe through this API we can allow some reference.. I think we should discuss this)
    • Tags should contain a reference to the user, email, and short link
Path: /code/tagcode
Resolved  → `{ code: "code", tag: "tagcode"}`
Path: /abc123/zyx987
Resolved  → `{ code: "abc123", tag: "zyx987"}`

Resolves tag as empty string if it doesn't exist

Path: /abc123
Resolved  → `{ code: "abc123", tag: "" }`

Ignores extra params

Path: /abc123/zyx987/ignored
Resolved  → `{ code: "abc123", tag: "456" }`

Fix lint errors to specify key

Screenshot 2023-08-26 at 8 18 54 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants