chore(js): improve jest watch performance by excluding node_modules #6084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanLondon
changed the title
mcous
approved these changes
Jul 8, 2020
shlokamin
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jest in watch mode consumes a lot of file watcher resources. It's watching many
node_modulesfiles it doesn't need to watch. On Linux, even after adding inotify resources,yarn jest --watch(or evenyarn jest --watch protocol-designer/src) takes a few minutes to start and sometimes times out a few times unless I kill flow or something and try again.Related issue: jestjs/jest#3254
Changelog
Update Jest config to exclude any
/node_modules/paths from the file watchReview requests
Risk assessment
low to medium, messing with jest config