Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): Constrain jsonschema dependency to current major version #5006

Merged
merged 1 commit into from Feb 18, 2020

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Feb 15, 2020

Overview

This PR tweaks #5005.

jsonschema uses semantic versioning. So, we can specify that we don't want their next breaking change.

jsonschema has already had one major version bump since we've started using it, apparently. That could have included breaking changes that affect us; we're lucky it didn't.

Review requests

Should we also change this in the Pipfile?

jsonschema = "==3.0.2"

Further reading

@SyntaxColoring SyntaxColoring added api Affects the `api` project chore labels Feb 15, 2020
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner February 15, 2020 02:01
@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #5006 into release_3.16.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release_3.16.0    #5006   +/-   ##
===============================================
  Coverage           68.33%   68.33%           
===============================================
  Files                1071     1071           
  Lines               35649    35649           
===============================================
  Hits                24362    24362           
  Misses              11287    11287

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61787e6...f784e45. Read the comment docs.

Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since everything else is pinned, should we pin the jsonschema version (maybe to latest 3.2.0) instead of this? Should we pin Numpy too?

@sfoster1
Copy link
Member

Since everything else is pinned, should we pin the jsonschema version (maybe to latest 3.2.0) instead of this? Should we pin Numpy too?

I generally prefer version constraints because it makes this more amenable to installing on your system outside of a virtualenv. That's doubly true for something like numpy, where since most of our users are scientists they probably have it installed and are quite particular about their version; and jsonschema, which is a transitive dependency of many other things.

@sfoster1 sfoster1 merged commit e76d2e3 into release_3.16.0 Feb 18, 2020
@sfoster1 sfoster1 deleted the api_fix-jsonschema-version-specifier branch February 18, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants