Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Goodway In wall relay #2619

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tszalaj
Copy link

@tszalaj tszalaj commented Nov 21, 2021

I created a configuration file for Goodway In wall switch using documentation provided on webpage: https://products.z-wavealliance.org/products/2948. I've tested it with the device on Domoticz. Configuration works and device reports it's outputs state changes.

Added support for Goodway In-wall switch TD13010.
Added support for Goodway In wall switch TD13010.
Update manufacturer_specific.xml
@tszalaj tszalaj changed the title Tszalaj patch 1 Support for Goodway In wall relay Nov 22, 2021
@nechry
Copy link
Member

nechry commented Nov 24, 2021

@tszalaj can you fix the xlmtest errors

Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:21: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:24: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:38: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:41: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:44: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:47: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:50: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:71: element CommandClass: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}CommandClass', attribute 'ForceInstances': The attribute 'ForceInstances' is not allowed.

run make xmltest to valid it, and then update your PR, thank-you

unit=>units

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants