Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TinyUSB to latest / Xbox One Auth fix #1002

Merged
merged 5 commits into from May 28, 2024

Conversation

arntsonl
Copy link
Contributor

@arntsonl arntsonl commented May 5, 2024

This updates our TinyUSB to the latest library. This removes the get_report hack I added in while tinyusb was updated, and brings us up to 4/30/2024 in the TinyUSB library.

@arntsonl arntsonl marked this pull request as ready for review May 5, 2024 20:48
…e of race condition (which seemed to be happening)
@arntsonl
Copy link
Contributor Author

arntsonl commented May 7, 2024

I'm still having issues on this one for Xbox One

@arntsonl arntsonl marked this pull request as draft May 13, 2024 14:04
.init, .reset, and .open are called multiple times during USB discovery

initial announcement code was moved from .init to .open AFTER the xbox one interface type is declared.

Also moved shared buffers to more sane areas and used two instead of one buffer for sharing.
@arntsonl arntsonl marked this pull request as ready for review May 28, 2024 04:09
@arntsonl
Copy link
Contributor Author

This should be fixed and ready to go. The issue was my Xbox One start/announce code was in the .init = function of TinyUSB driver. Because .init, .reset and .open can be opened multiple times on start of a device, I had to move the start/announce code of the controller into .open and ONLY when the device vendor is verified and the interfaces are setup.

This matches the XGIP I've seen on other devices, where they send 2 announces and then do auth.

@arntsonl arntsonl changed the title Update TinyUSB to latest Update TinyUSB to latest / Xbox One Auth fix May 28, 2024
Copy link
Contributor Author

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixed up

@arntsonl arntsonl merged commit b2fb7fe into OpenStickCommunity:main May 28, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant