Extend the p11test to support kryoptic #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakuje
force-pushed
the
p11test-kryoptic
branch
5 times, most recently
from
640e101
to
a875fdd
Compare
frankmorgner
requested changes
May 15, 2024
In the past the queries for the interface were passed through directly to the underlying pkcs11 module. But this could cause an issue if the caller requested specific version reported by the GetInterfaceList. This changes improves faking of the version numbers and maps the minor versions to the correct major versions of the API.
The invalid or unknown RSA OAEP decryption parameters caused the session kept holding the operation as started and all following operations failed as other operation was in progress.
frankmorgner
approved these changes
May 17, 2024
|
Merging. Thank you for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly fixes some corner case of the p11test that were caught while running it against kryoptic, adding new mechanisms and verifying the work as expected (while fixing some bugs on the kryoptic side too).