Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card-piv.c - Card matching fix for unknown card #3112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dengert
Copy link
Member

@dengert dengert commented Apr 12, 2024

During card matching, only use GET DATA of Discovery object before or in place of SELECT AID, if the ATR matches a known card or user has forced the card type or forced the use of a PIV driver.

This avoids possible state change in the unknown card if used by other processes.

partial fox for #3108

On branch piv-fix-#3108
Changes to be committed:
modified: card-piv.c

Checklist
  • Documentation is added or updated
  • New files have a LGPL 2.1 license statement
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

During card matching, only use GET DATA of Discovery object before
or in place of SELECT AID, if the ATR matches a known card or user
has forced the card type or forced the use of a PIV driver.

This avoids possible state change in the unknown card if used by other processes.

partial fox for OpenSC#3108

 On branch piv-fix-OpenSC#3108
 Changes to be committed:
	modified:   card-piv.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant