Fix OpenPGP select data #2753
Fix OpenPGP select data #2753
Conversation
frankmorgner
commented
Apr 14, 2023
frankmorgner
commented
- PKCS#11 module is tested
- Windows minidriver is tested
- macOS tokend is tested
There was a problem hiding this comment.
good catch. Please, remind me with the next release that I should test the Nitrokey/Gnuk token I have in my drawer. For some reason, I missed that one while testing the 0.23.0: https://github.com/OpenSC/OpenSC/wiki/Smart-Card-Release-Testing#opensc-0230 🤦
Verified that this solves the issue with my token.
|
Hello! I found a bug, in this change, while I was debugging related issue on Yubikey (#2969). It seems that this change is ignoring any errors from SELECT DATA, but, such errors might indicate that select failed, so, next GET_DATA will read same cert with id 0, as it would read without SELECT DATA. I found this issue in XCA - when I was importing attestation certs from my Yubikey, first (AUT) imported successfully, but when I was importing SIG, it complained, that such cert was already imported as AUT - I compared both certs, and they were the same. |
