Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose sound sources #21409

Merged
merged 1 commit into from May 4, 2024
Merged

Dispose sound sources #21409

merged 1 commit into from May 4, 2024
+5 −0

Conversation

PunkPun
Copy link
Member

@PunkPun PunkPun commented Apr 24, 2024

fixes [ALSOFT] (WW) 256 Sources not deleted

Mailaender
Mailaender approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@Mailaender Mailaender left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do no harm on Linux, but the mentioned warning is also not displayed in the first place.

@Mailaender Mailaender merged commit d91d1f5 into OpenRA:bleed May 4, 2024
3 checks passed
@Mailaender
Copy link
Member

Changelog

@PunkPun PunkPun deleted the fix-al branch May 4, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mailaender Mailaender Mailaender approved these changes

@RoosterDragon RoosterDragon RoosterDragon approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PunkPun @Mailaender @RoosterDragon @abcdefg30