Carryall: render no shadow from sprite actor.

[dnqbob]

No description provided.

[pchote]

Why? We do want to render the shadow…?

[dnqbob]

We use WithShadow to render a shadow right on the ground, not just at the actor place. I will show you an example of extra shadow problem.

[dnqbob]

As you see the Carryall render shadow of passenger in the mid-air, and there is also a shadow of passenger rendered on the ground by WithShadows. It is no doubt that The one rendered by WithShadows makes sense.

@pchote

[dnqbob]

And this is what happens when we apply this PR:

[dnqbob]

Why? We do want to render the shadow…?

In any case, our Carryall must be Aircraft, their shadow together with passenger's shadow will all be done by WithShadows.

[pchote]

That looks like a bug with shattered paradise not declaring shadows properly. Can you reproduce the issue in TS?

[dnqbob]

@pchote

[pchote]

Ok, but i'm not convinced this is the correct solution - it used to work properly without this change, and its not the only regression (voxels no longer follow the rotation of the carryall) suggesting that the bug may be somewhere else.

[dnqbob]

it used to work properly without this change

For god's sake, you can test it at 5cc1405, I have seen this bug since 2021.

This is an old bug actually, I guess it is just no one notice it.

[dnqbob]

its not the only regression (voxels no longer follow the rotation of the carryall) suggesting that the bug may be somewhere else

Voxels shouldn't be related to this issue, and voxels' shadow work well. This bug only happens to sprites that use shadow.