-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tox command added for readiness #8828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snwagh
changed the title
WIP: Tox command added for readiness but has bugs
Tox command added for readiness but has bugs
May 17, 2024
snwagh
changed the title
Tox command added for readiness but has bugs
Tox command added for readiness
May 22, 2024
itstauq
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @snwagh 🚀. Left some minor comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dev.k8s.ready
that will check a k8s deployment for readiness of various services.tox -e dev.k8s.ready -- frontend backend proxy
to check iffrontend
,backend
,proxy
are ready. The full set of posargs is{frontend backend proxy mongo seaweedfs registry}
(order is immaterial).curl http://localhost:${CLUSTER_HTTP_PORT}/api/v2/metadata
syft.test.helm
dev.k8s.ready
seaweedfs
andregistry
services (missing previously)override
posarg that will allow syft to be deployed in resource constrained environments (more notes below)Affected Dependencies
NA
How has this been tested?
tox -e syft.test.helm
CLUSTER_NAME=<CLUSTER_NAME> tox -e dev.k8s.ready -- frontend seaweedfs registry
to check health offrontend
,seaweedfs
, andregistry
Resource constraint testing
Testing succeeded all the way down till a single CPU and 2GB of RAM (Hypothesis is that things should work till about 1.5GB give or take; 1CPU, 1GB unfortunately gets all but the backend pod running)! Follow these instructions to witness this incredible feat of achievement by the Syft team!
tox -e syft.test.helm -- override
(this will run all the notebook tests). Exceptnotebooks/api/0.8/11-container-images-k8s.ipynb
all other tests should pass (if you set about 4GB of RAM, this test should pass as well).Set resource constraints
Check for successful deployment using k9s
Notebook tests
Docker resource usage
11th Test (
notebooks/api/0.8/11-container-images-k8s.ipynb
) with 4GB RAM.Checklist