Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename project.start, add deprecated decorator #8819

Merged
merged 3 commits into from
May 15, 2024

Conversation

eelcovdw
Copy link
Contributor

@eelcovdw eelcovdw commented May 15, 2024

Description

fixes https://github.com/OpenMined/Heartbeat/issues/1263

Adds a deprecated decorator with deprecation warning (default) or SyftError. Behaviour discussed with @IrinaMBejan :

image

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@koenvanderveen koenvanderveen merged commit 82a9231 into dev May 15, 2024
29 checks passed
@koenvanderveen koenvanderveen deleted the eelco/rename-project-start branch May 15, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants