Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook documentation for deploying PySyft #8796

Merged
merged 14 commits into from
May 17, 2024

Conversation

itstauq
Copy link
Member

@itstauq itstauq commented May 9, 2024

Description

Closes OpenMined/Heartbeat#1216

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@itstauq itstauq self-assigned this May 9, 2024
@itstauq itstauq requested review from yashgorana and snwagh May 9, 2024 10:45
@itstauq itstauq changed the title Add notebook documentation for deploying PySyft on a local k8s cluster Add notebook documentation for deploying PySyft May 13, 2024
Copy link
Contributor

@snwagh snwagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good stuff @itstauq!

Copy link
Collaborator

@rasswanth-s rasswanth-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done @itstauq

@rasswanth-s
Copy link
Collaborator

rasswanth-s commented May 17, 2024

@IrinaMBejan , This PR is currently blocking the Hagrid Deprecation.

Since this is a Documentation PR, and we could update it easily

I merging this PR early to unblock hagrid deprecation.

Feel free to comment on the same PR for review.

We could address the comments in a follow-up PR.

@rasswanth-s rasswanth-s merged commit 4fb8177 into dev May 17, 2024
29 checks passed
@rasswanth-s rasswanth-s deleted the tauquir/local-k8s-quickstart-doc branch May 17, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants