Attestation service in Syft #8659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snwagh
force-pushed
the
snwagh/attestation-service
branch
from
b6a11be
to
0f2d081
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
snwagh
commented
Apr 16, 2024
…yft into snwagh/attestation-service
itstauq
requested changes
Apr 29, 2024
packages/syft/src/syft/service/attestation/attestation_endpoints.py
Outdated
Show resolved
Hide resolved
rasswanth-s
reviewed
May 3, 2024
packages/syft/src/syft/service/attestation/attestation_service.py
Outdated
Show resolved
Hide resolved
|
Tested the Workflow, works great |
rasswanth-s
reviewed
May 3, 2024
rasswanth-s
reviewed
May 3, 2024
rasswanth-s
reviewed
May 3, 2024
|
|
||
| return "False" | ||
| # Fetch token from Micrsoft Attestation library | ||
| cpu_token = subprocess.run( |
There was a problem hiding this comment.
Leaving a note , for later, we do two calls, to the attestation client library , we could combine them in to a single call in later PR's
There was a problem hiding this comment.
Will shelf this as a TODO item, good point though.
rasswanth-s
approved these changes
May 3, 2024
rasswanth-s
reviewed
May 6, 2024
packages/syft/src/syft/service/attestation/attestation_service.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an attestation endpoint in Syft