Fix Multi Cluster Deployment in Devspace. #8610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a new tox task to list port mapping in multi cluster deployments
rasswanth-s
requested review from
teo-milea and
yashgorana
and removed request for
teo-milea
rasswanth-s
commented
Mar 21, 2024
yashgorana
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Thank you for accommodating the changes @rasswanth-s. This looks much neater now!
yashgorana
approved these changes
Apr 23, 2024
yashgorana
reviewed
May 7, 2024
scripts/k8s/launch_enclave.sh
Outdated
| bash -c '\ | ||
| export CLUSTER_NAME=testenclave1 CLUSTER_HTTP_PORT=9083 DEVSPACE_PROFILE=enclave && \ | ||
| tox -e dev.k8s.start -- --volume /sys/kernel/security:/sys/kernel/security --volume /dev/tmprm0:/dev/tmprm0 && \ | ||
| tox -e dev.k8s.hotreload' |
There was a problem hiding this comment.
i'm thinking since you're creating these scripts - might as well make them tox commands?
tox -e dev.k8s.launch.domain
tox -e dev.k8s.launch.gateway
tox -e dev.k8s.launch.enclave
There was a problem hiding this comment.
That's a good idea , adding them now 👍
There was a problem hiding this comment.
Resolved in 2c15bd0
There was a problem hiding this comment.
I have added a posargs to tox, so we could easily switch between deploy and hotreload mode.
Domain in Deploy Mode
tox -e dev.k8s.launch.domainDomain in Hot Reload Mode
tox -e dev.k8s.launch.domain -- hotreload
yashgorana
reviewed
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes
Affected Dependencies
Devspace deployments.
How has this been tested?
Checklist