New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uv
in backend container
#8605
Conversation
Haven't tested this rigorously so please don't merge |
uv
in backend containeruv
in backend container
uv
in backend containeruv
in backend container
e9d3b86
to
5253f18
Compare
Y# Please enter a commit message to explain why this merge is necessary,
@@ -886,7 +886,8 @@ commands = | |||
bash -c 'k3d --version' | |||
|
|||
; create registry | |||
bash -c 'k3d registry create registry.localhost --port 5800 -v $HOME/.k3d-registry:/var/lib/registry || true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local path $HOME/.k3d-registry
gets mounted on the docker macos VM through virtiofs. Might be a reason why docker push gets stuck at some point. For now just use docker-native volume to make sure there's no virtiofs involved happening during a push.
ENV UV_HTTP_TIMEOUT=600 | ||
|
||
# keep static deps separate to have each layer cached independently | ||
# if amd64 then we need to append +cpu to the torch version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish PyTorch would fix this somehow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that --index-url for cpu installs is annoying because setup.cfg doesn't support it - else things would've been easier.
Plus uv also has this issue with +cpu monikers at the moment. I've mentioned it here - astral-sh/uv#1497 (comment) & they're looking into it astral-sh/uv#3437.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @yashgorana
Description
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist