Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Jumplist functionality #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ScottIsAFool
Copy link
Member

This is to fix issue #96

/// <param name="action"></param>
/// <param name="writable">if set to <c>true</c> [writable].</param>
/// <param name="onlyIfChanged">if set to <c>true</c> [only if changed].</param>
/// <param name="action">The action.</param>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this auto-generated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of, I used GhostDoc as one of them was missing (writable one). I can remove if preferred.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say remove or provide more meaningful descriptions.

@martinwoodward
Copy link
Member

I think I'd rather us figure out how to get JumpLists working rather than remove the code entirely. If it's a side by side issue with WLW then we shouldn't worry about that too much as the number of users running WLW with OLW will likely decrease once we have got OLW stable and at feature parity.

@timheuer
Copy link
Member

I agree with @martinwoodward -- the suggestion was that if .wpost was registered as a type for OLW that this would 'work' -- I'm not entirely sure this is correct, but would like us to go that route first.

@ScottIsAFool
Copy link
Member Author

That's fine, this PR can be left to come back to depending on what we find for registering the wpost extension. If that works, we can close it, if it doesn't we can merge it :)

@martinwoodward
Copy link
Member

Ok if we close it for now but keep the branch alive? We can always press the Re-open button if we decide to go that route.

@colhountech
Copy link

I don't think it's a side-by-side issue. I'm running Windows 10 Pro Version 1511, OS Build 10586.29 and don't have WLW installed, and I get that big message box popup every time I publish.

My fix was to disable jumplists for windows 10:

public static bool CanShowJumpList() { return PlatformHelper.RunningOnWin7OrHigher() && !PlatformHelper.RunningOnWin10(); }

public static bool RunningOnWin10()
{
Version version = Environment.OSVersion.Version;
return (version.Major == 6 && version.Minor == 2);
}

@willduff
Copy link
Member

Parking this until we have a little more discussion in issue #96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants