Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to have version range end with the next minor version #27987

Merged
merged 1 commit into from Mar 25, 2024
Merged

Update to have version range end with the next minor version #27987

merged 1 commit into from Mar 25, 2024

Conversation

jhanders34
Copy link
Member

@jhanders34 jhanders34 commented Mar 23, 2024 •
edited

  • Instead of using a micro version of .100 or .200 for the end range for bundle dependencies which will eventually lead to errors once the micro version in liberty changes to 100 or more in the next year, just use the minor version that is +1 of the lower range.

The range for feature files changes from [1.0.0, 1.0.200) to [1.0.87, 1.1.0) for bundles with version 1.0 if .87 is the micro version for that release of liberty.

@jhanders34 jhanders34 self-assigned this Mar 23, 2024
@jhanders34
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=a3022b4a-436b-403c-a11a-b056b3c0e02b

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_JqmqoeinEe6_pbTBHNL0pQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=a3022b4a-436b-403c-a11a-b056b3c0e02b has errors/failures.

@jhanders34
Update to have version range end with the next minor version
1e1b835 
- Instead of using a micro version of .100 or .200 for the end range for
bundle dependencies which will eventually lead to errors once the micro
version in liberty changes to 100 or more in the next year, just use the
minor version that is +1 of the lower range.
@jhanders34
Copy link
Member Author

#libby #build

@LibbyBot
Copy link

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=3084e637-cea2-4fd1-8b70-f61b1bc829ea

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_OcLlAOkwEe6MpPO8M5EK5Q

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 51 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 5 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 150 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 1 BVT files were changed.

  • Check that the build did not break the affected BVT suite(s).

  • 5 unit test files were changed.

  • Check that the build did not break the affected unit test suite(s).

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=3084e637-cea2-4fd1-8b70-f61b1bc829ea has errors/failures.

@LibbyBot
Copy link

The build jhanders34-27987-20240323-1023
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_OcLlAOkwEe6MpPO8M5EK5Q
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_OcLlAOkwEe6MpPO8M5EK5Q

cbridgha
cbridgha approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@cbridgha cbridgha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jhanders34 jhanders34 merged commit e2e7688 into OpenLiberty:integration Mar 25, 2024
2 of 4 checks passed
@jhanders34 jhanders34 mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjwatson tjwatson tjwatson approved these changes

@cbridgha cbridgha cbridgha approved these changes

Assignees

@jhanders34 jhanders34

Labels
CLA Signed team:Performance
Projects
None yet
Milestone
[Iteration 24.6] Mar 18 - Mar 29
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhanders34 @LibbyBot @tjwatson @cbridgha