Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #27775: Upgrade commons compress to 1.26 #27776

Merged
merged 1 commit into from Mar 20, 2024
Merged

Issue #27775: Upgrade commons compress to 1.26 #27776

merged 1 commit into from Mar 20, 2024

Conversation

hlhoots
Copy link
Member

@hlhoots hlhoots commented Feb 28, 2024

#build

fixes #27775

@LibbyBot
Copy link

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=1d8f66f0-7792-4c2a-8ef0-9f3543cb9bf4

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_FNbTANZDEe6vioT4Ep3iAw

Target locations of links might be accessible only to IBM employees.

@idlewis
Copy link
Member

idlewis commented Feb 28, 2024

I've been looking at this from a JMX archive expander POV.
It looks as though compress 1.26 has introduced a dependency on commons-io. I've been playing around in pr #27720
Although I haven't got very far as my build env is very out of date, and causing me issues.

@hlhoots hlhoots force-pushed the 27775-UpgradeCommonsCompress126 branch from c073201 to 813abbe Compare February 28, 2024 18:45
@hlhoots
Copy link
Member Author

hlhoots commented Feb 28, 2024

#build

@LibbyBot
Copy link

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=7c2e6d29-e890-4a95-8242-c7e7219a0b5a

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_WcGp4NZhEe6vioT4Ep3iAw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=1d8f66f0-7792-4c2a-8ef0-9f3543cb9bf4 has errors/failures.

@hlhoots hlhoots force-pushed the 27775-UpgradeCommonsCompress126 branch from 813abbe to 59ce57b Compare February 28, 2024 21:56
@hlhoots
Copy link
Member Author

hlhoots commented Feb 28, 2024

#build

@LibbyBot
Copy link

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=a87bb222-0d66-40cc-995b-0cb95ebae32d

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_CQQnYNZ8Ee6vioT4Ep3iAw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=7c2e6d29-e890-4a95-8242-c7e7219a0b5a has errors/failures.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=a87bb222-0d66-40cc-995b-0cb95ebae32d has errors/failures.

@hlhoots hlhoots force-pushed the 27775-UpgradeCommonsCompress126 branch from 59ce57b to 5f79e5a Compare February 29, 2024 14:42
@hlhoots
Copy link
Member Author

hlhoots commented Feb 29, 2024

#build

@LibbyBot
Copy link

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=4e37d391-4aec-471f-b7bc-f6c73a32c331

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_vun9INcIEe6vioT4Ep3iAw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=4e37d391-4aec-471f-b7bc-f6c73a32c331 has errors/failures.

@hlhoots hlhoots force-pushed the 27775-UpgradeCommonsCompress126 branch from 5f79e5a to 1ae722b Compare March 1, 2024 18:01
@hlhoots
Copy link
Member Author

hlhoots commented Mar 1, 2024

#build

@LibbyBot
Copy link

LibbyBot commented Mar 1, 2024

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=4e1d4f51-ef64-4adc-a17e-e62d56922817

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Mar 1, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_btE3UNftEe6vioT4Ep3iAw

Target locations of links might be accessible only to IBM employees.

cbridgha
cbridgha previously approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@cbridgha cbridgha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@LibbyBot
Copy link

LibbyBot commented Mar 2, 2024

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=4e1d4f51-ef64-4adc-a17e-e62d56922817 has errors/failures.

@LibbyBot
Copy link

LibbyBot commented Mar 2, 2024

The build hlhoots-27776-20240301-1012
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_btE3UNftEe6vioT4Ep3iAw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_btE3UNftEe6vioT4Ep3iAw

@hlhoots
Copy link
Member Author

hlhoots commented Mar 3, 2024

errors and timeouts. rebuild for hopeful clarity.

#build

@LibbyBot
Copy link

LibbyBot commented Mar 3, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Kojw0Nl2Ee6LD_Ez57gyQg

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Mar 3, 2024

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=2d4d4287-ceca-4340-9072-9f3dc05cfb33

Target locations of links might be accessible only to IBM employees.

@hlhoots
Copy link
Member Author

hlhoots commented Mar 13, 2024

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Ye36wOFVEe62Qc2Tit17uw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=797b44a4-9f27-44b1-a80a-3843b5ae45dc

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=797b44a4-9f27-44b1-a80a-3843b5ae45dc has errors/failures.

@LibbyBot
Copy link

The build hlhoots-27776-20240313-1031
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Ye36wOFVEe62Qc2Tit17uw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_Ye36wOFVEe62Qc2Tit17uw

@hlhoots
Copy link
Member Author

hlhoots commented Mar 14, 2024

The latest builds had some errors, but nothing seems to be related to the commons-compress upgrade. A majority of the failures were in UI related buckets with java.net.ConnectException: 2024-03-14-11:15:45:087 Connection refused failures.

cbridgha
cbridgha previously approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@cbridgha cbridgha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hlhoots
Copy link
Member Author

hlhoots commented Mar 14, 2024

#build

@hlhoots hlhoots force-pushed the 27775-UpgradeCommonsCompress126 branch from 96fb813 to 30ec11b Compare March 14, 2024 15:29
@LibbyBot
Copy link

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=bb495fc6-6928-4fc7-bb41-534fbfeb7b3b

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_wVhV0OIQEe62Qc2Tit17uw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=bb495fc6-6928-4fc7-bb41-534fbfeb7b3b has errors/failures.

@LibbyBot
Copy link

The build hlhoots-27776-20240314-0850
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_wVhV0OIQEe62Qc2Tit17uw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_wVhV0OIQEe62Qc2Tit17uw

@hlhoots hlhoots force-pushed the 27775-UpgradeCommonsCompress126 branch from 30ec11b to 4b5e981 Compare March 19, 2024 19:12
@hlhoots
Copy link
Member Author

hlhoots commented Mar 19, 2024 •
edited

#build

The commons.io upgrade seems to now return a NoSuchFileException instead of the previous FileNotFoundException for the FileUtils.readFileToString(file, "UTF-8") method called in FilePersistenceProvider.java. Thus updated 2 com.ibm.ws.ui product files to handle that accordingly based on talks with ui team.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_AIC4oOYdEe6_pbTBHNL0pQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=16087d25-f4c6-4569-8814-bfa0cb921556

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=16087d25-f4c6-4569-8814-bfa0cb921556 has errors/failures.

@LibbyBot
Copy link

The build hlhoots-27776-20240319-1226
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_AIC4oOYdEe6_pbTBHNL0pQ
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_AIC4oOYdEe6_pbTBHNL0pQ

@hlhoots
Copy link
Member Author

hlhoots commented Mar 20, 2024

RTC build had an failure related to the changes in com.ibm.ws.ui as it tried to run a FAT bucket called com.ibm.ws.ui_fat which doesnt exist. The cog build had 4 buckets that had errors, however there were corresponding existing defects for those errors. Should be good to merge after review.

@hlhoots hlhoots requested a review from aknguyen7 March 20, 2024 16:31
aknguyen7
aknguyen7 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@aknguyen7 aknguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes in FilePersistenceProvider.java and PlainTextLoaderService.java , they LGTM

@hlhoots
Copy link
Member Author

hlhoots commented Mar 20, 2024

#libby

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 9 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 1 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • 14 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

@hlhoots hlhoots merged commit 89aa82e into OpenLiberty:integration Mar 20, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblye jimblye jimblye approved these changes

@aknguyen7 aknguyen7 aknguyen7 approved these changes

@tbitonti tbitonti tbitonti approved these changes

@cbridgha cbridgha cbridgha left review comments

Assignees
No one assigned
Labels
CLA Signed target:24004
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade org.apache.commons.compress to 1.26
8 participants
@hlhoots @LibbyBot @idlewis @cbridgha @jimblye @aknguyen7 @tbitonti @clarkek123