GitHub Actions Test for ci.common 33-SNAPSHOT #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherylking
requested changes
Mar 13, 2024
|
So are you going to change LMP to use the new constructor that doesn't take all the parameters? |
cherylking
requested changes
Mar 27, 2024
| @@ -394,6 +395,14 @@ protected ServerConfigDocument getServerConfigDocument(CommonLoggerI log, File s | |||
| return scd; | |||
| } | |||
|
|
|||
| protected ServerConfigDocument getServerConfigDocument(CommonLoggerI log, File serverXML, Map<String, File> libertyDirPropertyFiles) throws IOException { | |||
| if (scd == null || !scd.getServerXML().getCanonicalPath().equals(serverXML.getCanonicalPath())) { | |||
| scd = new ServerConfigDocument(log, libertyDirPropertyFiles); | |||
There was a problem hiding this comment.
This is interesting. Is this because of how our tests are setup/run that this is necessary? Also, I see all builds failing. Do you know the cause? I'm not going to dive into the logs at this point and try to figure it out myself.
There was a problem hiding this comment.
The tests are passing in latest run, but I would still like to understand this change and why it was necessary.
There was a problem hiding this comment.
This logic was introduced by this PR, which was on the subject of thread safety. I think the move from static makes this piece not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructor for ServerConfigDocument to be deprecated