Add power limiting functionallity for inverter #271
Conversation
crasu
force-pushed
the
feature/add-set-active-rate
branch
2 times, most recently
from
1cf6ceb
to
ab799f8
Compare
|
For an easier review I think it might be a good idea so separate the formatting changes from the behavioural changes. |
|
@crasu Is this PR dead? If so, I need this functionality too and I have changed the sources already without knowing the PR existed. I could provide an alternative PR then. |
crasu
force-pushed
the
feature/add-set-active-rate
branch
from
ab799f8
to
757f5a3
Compare
|
@ViRuSTriNiTy If you can like you can update the pr and I will be happy to merge it. |
Signed-off-by: crasu <spam@crasu.de>
crasu
force-pushed
the
feature/add-set-active-rate
branch
from
757f5a3
to
488d222
Compare
|
I rebased the PR to the current master (untested) |
|
Can someone test this? |
|
Sure, I am going to update and test it today for protocol version 1.24. |
| @@ -139,6 +139,8 @@ The following mqtt commands are defined for protocol 1.24: | |||
| gridfirst/set/powerrate | |||
| gridfirst/set/stopsoc | |||
| gridfirst/set/timeslot | |||
| power/set/activeRate | |||
There was a problem hiding this comment.
Since the other commands are defined using all-lower case we should use all-lower case here too, right?
| @@ -33,6 +33,7 @@ Implemented Features: | |||
| * Currently Growatt v1.20, v1.24 and v3.05 protocols are implemented and can be easily extended/changed to fit anyone's needs | |||
| * TLS support for esp32 | |||
| * Debugging via Web and Telnet | |||
| * Power limiting (aka Nulleinspeisung) | |||
There was a problem hiding this comment.
Can we remove or rephrase the "aka Nulleinspeisung" because Nulleinspeisung is a german term and it is something you can achieve with the power limiting feature but the feature could also be used to solve other issues too. Rephrasing it as "allows zero feed-in" or something would work from my perspective.
There was a problem hiding this comment.
The english term for "Nulleinspeisung" would be "zero export". Zero export requires a connected meter via RS485 or a constant adjustment of the export rate. If you want a very accurate regulation you have to connect a meter. In this case the inverter will adjust the export a few times per second.
I added some review comments but I am unsure how I can update your PR since it is originating from your fork where I have no permissions. Is updating even possible from my side? Nope, doesn't work. You need to grant me the permission to commit changes:
|
Afaik - You need to open your own pr from my branch |
No description provided.