Topics Tags on Main Page #74
Conversation
search/templates/cosmos/index.html
Outdated
| <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-beta.2/css/bootstrap.min.css" integrity="sha384-PsH8R72JQ3SOdhVi3uxftmaW6Vc51MKb0q5P2rRUpPvrszuE4W1povHYgTpBfshb" crossorigin="anonymous"> | ||
| <link href="https://fonts.googleapis.com/css?family=Roboto+Mono" rel="stylesheet"> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css"> | ||
| <style> |
There was a problem hiding this comment.
You must move the css code to its own file and link it here. 👍
search/views.py
Outdated
| @@ -37,14 +52,48 @@ def error404(request): | |||
| def error500(request): | |||
| return render(request, 'cosmos/error/HTTP500.html') | |||
|
|
|||
| # Generate all combinations of a search literal | |||
There was a problem hiding this comment.
This pull request brings in the changes from your previous pull request. You might want to separate it for independent review.
|
Nice work 👍 I have added a few comments. Kindly take a look and make appropriate changes. 👍 |
|
Hi, For the topic tags to return all results while keeping the tabs clean, we would need the previous function! |
|
@xx621998xx Which function are you considering? Kindly resolve the conflicts and take a look at the above comments. |
|
Hi, The generate_perm function from the earlier pull request is required in this pull request. |
|
This feature is similar to the tags under the search bar of Quark. You must get tags from Kindly take a look into this and let us know if you need any help. |
|
|
||
| <head> |
There was a problem hiding this comment.
You are including the header {% extends 'cosmos/header.html' %}, so, you do not need this.
| <link rel="stylesheet" href="/home/sarthika/Documents/galsquared/cosmos-search/search/templates/cosmos/style.css"/> | ||
|
|
||
| </head> | ||
| <style> |
There was a problem hiding this comment.
You must move the css code to its own file.
| <article> | ||
| <body> |
There was a problem hiding this comment.
This is, in fact, inside of body tags: {% block body %}. You need to fix this code.
|
I have added a few comments. Take a look and make appropriate changes 👍 |
|
@xx621998xx Any updates on this feature? 🤔 Minor changes are required before this can be merged. If you are facing any trouble, kindly let us know and we will help you. 👍 |
Checklist
developbranch.Which issue does this PR fix?:
fixes: #63
This PR lists out some topics on the main page, clicking them leads one to the result page for those particular topics. There is a "more" button which can be clicked, opens up a drop down menu listing out all the topics.
Why do we need this PR?:
Usability improvement, better learning experience.
TODOs (if any):
Could add these as a left sidebar, perhaps?