Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting feature of anonymous user #73

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Shweta4321
Copy link
Contributor

Checklist

  • My branch is up-to-date with the upstream develop branch.
  • I have added necessary documentation (if appropriate).

Which issue does this PR fix?:
fixes: #60

Why do we need this PR?:
This would let the user rate the search result on scale of 1 to 5. It store the votes in database along with IP address and algorithm name .

If relevant, please include a screenshot.
screenshot from 2018-02-28 13-06-50
screenshot from 2018-02-28 13-37-47

@AdiChat
Copy link
Member

AdiChat commented Mar 1, 2018

Nice work 👍

You need to resolve the Travis error django.db.utils.OperationalError: no such table: search_votes. You need to register the Votes model in setting.py.

In terms of UI, you must remove the submit button and an entry must be made as soon as the user interacts with it. The average rating (in a format like [4.9 ⭐] ) should appear beside the algorithm name. You must, also, make a default entry of 5 rating for each algorithm, to begin with. 👍

Kindly make appropriate changes and let us know when it is ready for review. 👍

@Shweta4321
Copy link
Contributor Author

Shweta4321 commented Mar 2, 2018 via email

@Shweta4321 Shweta4321 force-pushed the master branch 2 times, most recently from 89521ed to 6d93cf5 Compare March 3, 2018 19:52
@Shweta4321
Copy link
Contributor Author

@AdiChat The build is failing because there are no commands regarding makemigrations and migrate in travis.yml. Shall i raise issue for the same?
It works on my pc.
screenshot from 2018-03-04 01-45-34
Travis output.
screenshot from 2018-03-04 01-45-05

@soc221b
Copy link

soc221b commented Mar 5, 2018

I think you can remove the table from your local DB, maybe it will regenerate the error on your PC, then you can fix it.

@Shweta4321
Copy link
Contributor Author

@iattempt I have already tried it. The main problem is as travis is not executing makemigrations and migrate command. So,it does not know about change in database hence this error occurs.

@soc221b
Copy link

soc221b commented Mar 5, 2018

Did you try to adding command python3 manage.py makemigrations to travis before test command?

@soc221b
Copy link

soc221b commented Mar 5, 2018

screen shot 2018-03-06 at 3 53 46 am
screen shot 2018-03-06 at 3 54 47 am

@Shweta4321
Copy link
Contributor Author

@AdiChat Please review.

@AdiChat
Copy link
Member

AdiChat commented Mar 30, 2018

As we are expanding to other sources of search results, providing feedback option to only Cosmos results may be odd.

You may convert this to a general feedback form located at the lower right corner as a popup. In addition to voting, you may add an option to add a comment and also, store the current url/ search term. The general structure should remain the same.

We can use this data to provide additional insights to users like trending search terms, better recommendations and others.

Kindly take a look into this. 👍

@Shweta4321
Copy link
Contributor Author

Shweta4321 commented Apr 2, 2018

@AdiChat please review

@Shweta4321
Copy link
Contributor Author

@AdiChat Please Review

@Shweta4321
Copy link
Contributor Author

@AdiChat Please Review

@AdiChat
Copy link
Member

AdiChat commented Apr 13, 2018

You must clean this pull request regarding manage.py 100755 → 100644, Submodule cosmos deleted from 2006c2 and similar changes.

@Shweta4321
Copy link
Contributor Author

@AdiChat please Review

@AdiChat
Copy link
Member

AdiChat commented Apr 14, 2018

Nice work 👍

It is intended to be a general voting section instead of being tied to a particular result. This requires a redesign of the UI to the lower right corner as a popup.

In the current design, voting reloads the page but ideally, it should cover everything in the background. For comments/ discussions, we must use our Discourse forum.

Instead of asking users to rate, we can ask a specific question like "What do you like about this page?" with options like "Code results, Video results, Everything". You can, also, take a look at third-party integrations that can provide such a solution.

Kindly take a look into this. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voting feature for anonymous users
3 participants