Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication through Google account #111

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

muskanchugh5
Copy link

@muskanchugh5 muskanchugh5 commented Apr 9, 2018

Checklist

  • My branch is up-to-date with the upstream develop branch.
  • I have added necessary documentation (if appropriate).

Which issue does this PR fix?:
fixes: #59

"First step for issue #59(Authentication through google account)
Why do we need this PR?:
To see the search history of any user ,we need his authentication first.
If relevant, please include a screenshot.

Demo (optional):

Some tips for you to write the instructions:

  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as migrating databases, etc.

Testing instructions:

If there is any work still left to do, please add it here.

TODOs (if any):

@khatryshikha
Copy link
Contributor

@muskan6769 , Are you still working on this?

@AdiChat
Copy link
Member

AdiChat commented Apr 16, 2018

Nice work 👍

The issue might be that a user has to sign up for our custom authentication but sign-up again for our Discourse instance which is an integral part. It will be nice to have a single authentication system.

For this, Discourse comes with its own SSO system which we can use from this purpose.

This will have the advantage that we will have single authentication system and we can focus more on features built over user activity.

Kindly take a look at it and let us know your thoughts. 👍

@muskanchugh5
Copy link
Author

@AdiChat I understood the issue....I'll work on it.

@muskanchugh5
Copy link
Author

muskanchugh5 commented Apr 19, 2018

@AdiChat.. Should I work upon ldap authentication.?

@AdiChat
Copy link
Member

AdiChat commented Apr 22, 2018

@muskan6769 Yes, you may proceed with it. 👍

Copy link

@winlover32 winlover32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication
4 participants