Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

click default remove #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

khatryshikha
Copy link
Contributor

Checklist

  • My branch is up-to-date with the upstream develop branch.
  • I have added necessary documentation (if appropriate).

Which issue does this PR fix?:
fixes: #
*Currently the search bar has a default tag in it when we open cosmos search.
*We need to click on X to remove them.
*Now just clicking on search bar will remove the default tag.

Why do we need this PR?:
I think that it is more intuitive if the default tag is removed when we click the search bar instead of clicking on the X.

If there is any work still left to do, please add it here.

TODOs (if any):
*Should I remove the X button?

@khatryshikha
Copy link
Contributor Author

@AdiChat please review.

@AdiChat
Copy link
Member

AdiChat commented Apr 17, 2018

Nice work 👍

The intention behind providing the default search term is to aid the user to explore new areas. I am not sure if it would help the user if we remove the default search term by clicking on the search bar as it prevents the user from interacting with the search term.

You have brought up an important issue where we need to customize the search bar. The search bar is ideally the first point of interaction so it must be made the best. We must explore new designs to make the experience the best.

Kindly take a look at it and share your thoughts. 👍

@khatryshikha
Copy link
Contributor Author

Thank you @AdiChat.😊
I understood your point. But I think that the person who might want to explore the random search result will directly hit the search button provided near the search bar. Only those people will click on the search bar who want the specific result to be searched. So direct click on it will save the time of the user.
And customizing the search bar is really important issue, hoping to work it!
Kindly suggest if there is anything better for implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants