Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication #59

Open
2 of 3 tasks
pragyach opened this issue Feb 20, 2018 · 17 comments · May be fixed by #111
Open
2 of 3 tasks

Authentication #59

pragyach opened this issue Feb 20, 2018 · 17 comments · May be fixed by #111

Comments

@pragyach
Copy link

I'm submitting a ... (check one with "x")

  • feature request

Description:
We can store user's search history similar to you tube,Chrome etc in order to make cosmos search more user specific.For doing this we may need to ask user to sign in with gmail or something else. As stated by @AdiChat "If we store user history, we can create exciting new features like personalized learning paths, develop the mental model of the user based on knowledge gained and many more. "

For this, I would like to start with the basic outlay for creating the authentication system and store the search history.

Would you like to work on this issue?

  • Yes
  • No
@AdiChat
Copy link
Member

AdiChat commented Feb 20, 2018

Sure. Go for it. Keep us updated on your progress. 👍

@vaibhavsingh97
Copy link
Member

@pragyach I would recommend you to check allauth. This has excellent support for authentication.
CC: @AdiChat

@flxwu
Copy link
Member

flxwu commented Feb 20, 2018

Or use firebase auth @pragyach @vaibhavsingh97 That's what I personally have been using since and I got along with it quite well, very feature-rich and still easy to use 👍

@pragyach
Copy link
Author

I have previously worked with firebase so I will once do it with firebase integration of Gmail and simultaneously I will check allauth and try it. @vaibhavsingh97 @Pl4gue

@pragyach
Copy link
Author

I have one more doubt.Shall we make a landing page similar to github where we can explain all about different features of cosmos-search and make compulsory for user to sign in with Gmail.Second option is we can just display sign in with Gmail option on top right corner of recent home page of cosmos-search.
Please suggest @AdiChat @Pl4gue

@AdiChat
Copy link
Member

AdiChat commented Feb 21, 2018

A landing page explaining the different features of Cosmos-search will be great. 🎉

Sign in should be optional such that any user may use the search engine but on signing in, one will enjoy benefits like personalized learning paths and others. Compulsory sign-in may discourage some users from using our search engine but may eventually, go for it on observing the upcoming benefits.

So, you may develop the personal accounts feature along with the custom landing page. 👍

@pragyach
Copy link
Author

OKay @AdiChat I will go forward with building landing page along with sign in and sign up option on top right which will be just like on-boarding kind.User will have an option to skip and can use cosmos search.

@pragyach
Copy link
Author

pragyach commented Feb 24, 2018

I have built landing page with sign in and sign up option simply just by email address.I will be adding gmail sign in option on top nav bar. @AdiChat please suggest suitable changes.
cosmo1090

@AdiChat
Copy link
Member

AdiChat commented Feb 25, 2018

The UI looks good. 👍

You may re-design the page as the current design gives an impression that signing up is mandatory though we aim to keep it optional but recommended.

You may design it as having the search bar in the middle of the page and the features may be displayed as the user scrolls down. Keep it simple. The sign-up option can be placed at the right top corner which may direct to a custom sign-up page.

Keep us updated on your progress. 👍

@pragyach
Copy link
Author

According to what you explained it would be better if I change our current cosmos-search page ui because all these features could be imported there along with same search option.Am I understanding it right @AdiChat ?

@arnavb
Copy link
Member

arnavb commented Feb 26, 2018

Hey @pragyach, just as a suggestion, you can also add Github authentication as well. (Most github based tools usually allow you to sign in with Github)

@pragyach
Copy link
Author

Hey @arnavb, Ya sure we can keep sign in with with github.Github has its own base platform for enabling its authentification.So firstly I will work with firebase then proceed with github.

@AdiChat
Copy link
Member

AdiChat commented Feb 26, 2018

Yes, you may integrate the authentication and place the sign-in and sign-up option at the upper right corner and keep the basic look of a search engine. 👍

@muskanchugh5
Copy link

@AdiChat...Can I take up this issue.

@AdiChat
Copy link
Member

AdiChat commented Mar 24, 2018

Sure @muskan6769 Go for it. 👍

@pragyach It has been a month with no activity towards this feature, so, we are opening this feature for contributors. No worries. 👍

@muskanchugh5
Copy link

muskanchugh5 commented Apr 7, 2018

@AdiChat I have a doubt.Authentication with google account is sufficient or should I also keep other option like fb or github...

@AdiChat
Copy link
Member

AdiChat commented Apr 8, 2018

To begin with, you can keep one sign-up option.

Other options can be integrated after the basic authentication system is deployed. 👍

@muskanchugh5 muskanchugh5 linked a pull request Apr 9, 2018 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants