Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

discover(...) fails, also may be irrelevant/unnecessary #54

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elias-ba
Copy link
Contributor

The function discover(httpMethod, resourceType) seems to be doing a job of parsing this url; https://dhis2.github.io/dhis2-api-specification/spec/metadata_openapi.json and giving informations about some httpMethod (I am not even sure why that matters). I have tested it and don't really see it's relevancy. It always returns this error message (in my case):

{
  request: undefined,
  error: "Cannot read property 'post' of undefined",
  response: undefined
}

In another hand, when I see the complexity of it's code, I am wondering if one wrote all this just for something that the user can read through documentation. In fact I am confused by this function. This PR is a deletion proposal of that function as it seems to add many lines of code for something that doesn't seem very interesting. Please @taylordowns2000 lmk what you think and let's take a decision. If you have the same point than me, then please merge this.

@elias-ba elias-ba self-assigned this Dec 24, 2021
@taylordowns2000 taylordowns2000 changed the title I don't think discover is relevant. discover(...) fails, also may be irrelevant/unnecessary Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants