Dem2mesh #904

pierotofy · 2018-10-19T22:24:43Z

This is a series of changes that replace odm_dsm2points and the call to PoissonRecon, which is the current approach to 2.5D meshing, with a new program, odm_dsm2mesh, which uses a gridded + quadratic simplification tiled approach to meshing.

The approach creates higher fidelity meshes from a DSM, keeps the memory usage linear via tile splitting (the mesh is split into tiles before triangulation and each tile is processed independently, then merged at the end), creates good sized triangles (important for texturing) and is reasonably fast.

I will post screenshots of orthophotos for comparison to the current method in the next several days, but I thought I'd ask for early feedback and some help with testing.

Given the novelty of the method, I was also thinking of publishing the odm_dsm2mesh program in a separate repository and pull it into the ODM build process. Let me know your thoughts about that. 😄

…generation

pierotofy · 2018-10-19T22:27:48Z

Future areas of improvement / research include DSM filtering and adding multi-threaded support.

smathermather · 2018-10-20T12:24:01Z

Agree on the separate repo — this is something that might help with other projects and will be harder to find and use if buried in ODM.

I’ll check this out on Monday. This is very exciting.

smathermather · 2018-10-22T16:11:20Z

I am liking this improvement a lot. What are the new flags and do we need a synchronized update to https://github.com/OpenDroneMap/docs?

smathermather · 2018-10-22T16:17:37Z

I'm not sure if this is a regression or an issue that was already extant, but I rerun the dataset, it appears some steps are rerunning in spite of all the data being there:

[INFO]    Running georeferencing with OpenSfM transformation matrix
[DEBUG]   running /home/useruser/OpenDroneMap/build/bin/odm_georef -bundleFile /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/opensfm/bundle_r000.out -inputTransformFile /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/opensfm/geocoords_transformation.txt -inputCoordFile /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_georeferencing/coords.txt -inputFile /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_texturing_25d/odm_textured_model.obj -outputFile /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_texturing_25d/odm_textured_model_geo.obj -inputPointCloudFile /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/smvs/smvs_dense_point_cloud.ply -outputPointCloudFile /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_25dgeoreferencing/odm_georeferenced_model.ply  -logFile /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_25dgeoreferencing/odm_georeferencing_log.txt -outputTransformFile /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_25dgeoreferencing/odm_georeferencing_transform.txt -georefFileOutputPath /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_25dgeoreferencing/odm_georeferencing_model_geo.txt
[DEBUG]   running /home/useruser/OpenDroneMap/SuperBuild/build/pdal/bin/pdal pipeline -i /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_georeferencing/las.json --readers.ply.filename=/mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_25dgeoreferencing/odm_georeferenced_model.ply
[INFO]    Calculating cropping area and generating bounds shapefile from point cloud
[DEBUG]   running pdal translate -i "/mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_georeferencing/odm_georeferenced_model.laz" -o "/mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_georeferencing/odm_georeferenced_model.filtered.las" decimation outlier range --filters.decimation.step=90 --filters.outlier.method=radius --filters.outlier.radius=2 --filters.outlier.min_k=2 --filters.range.limits='Classification![7:7]'
[DEBUG]   running pdal info --boundary --filters.hexbin.edge_length=1 --filters.hexbin.threshold=0 /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_georeferencing/odm_georeferenced_model.filtered.las > /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_georeferencing/odm_georeferenced_model.boundary.json
[DEBUG]   running pdal info --summary /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_georeferencing/odm_georeferenced_model.laz > /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_georeferencing/odm_georeferenced_model.summary.json
[DEBUG]   running ogr2ogr -overwrite -a_srs "+proj=utm +zone=37 +datum=WGS84 +units=m +no_defs" /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_georeferencing/odm_georeferenced_model.bounds.shp /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_georeferencing/odm_georeferenced_model.bounds.geojson
[INFO]    Running ODM Georeferencing Cell - Finished
[INFO]    Running ODM DEM Cell
[INFO]    Classify: False
[INFO]    Create DSM: False
[INFO]    Create DTM: False
[INFO]    DEM input file /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_georeferencing/odm_georeferenced_model.laz found: True
[WARNING] DEM will not be generated
[INFO]    Running ODM DEM Cell - Finished
[INFO]    Running ODM Orthophoto Cell
[WARNING] Found a valid orthophoto in: /mnt/bigdiskdisk/datadata/ODMProjects/stpbdem2mesh/odm_orthophoto/odm_orthophoto.png
[INFO]    Running ODM OrthoPhoto Cell - Finished
[INFO]    OpenDroneMap app finished - Mon Oct 22 16:14:40  2018

smathermather · 2018-10-22T16:30:57Z

I am liking this improvement a lot. What are the new flags and do we need a synchronized update to https://github.com/OpenDroneMap/docs?

Also, we should probably implement the version suggestions in this conversation.

pierotofy · 2018-10-22T19:22:16Z

No new flags since 0.4.0, but the docs haven't been updated since 0.3.1, so yes we should update them.

odm_georeferencing needs to be re-run if the mesh changes. I think it's always been that way. The point cloud doesn't change (that could be improved), but the mesh (and all subsequent steps that depend on it) do.

pierotofy · 2018-10-28T18:20:22Z

Current master:

This branch:

pierotofy · 2018-10-28T18:25:57Z

Current master:

This branch:

Not much improvement.

pierotofy · 2018-10-28T18:37:15Z

Current master:

This branch:

Hey that was a car?

pierotofy · 2018-10-28T19:26:43Z

Current master:

This branch:

pierotofy · 2018-10-28T19:29:14Z

Current master:

This branch:

pierotofy · 2018-10-28T19:32:19Z

Current master:

This branch:

Not much difference.

pierotofy · 2018-10-28T19:35:33Z

Current master:

This branch:

Not much difference, a bit straighter edges on rooftop.

pierotofy · 2018-10-28T22:01:08Z

One downside is currently that almost all --fast-orthophoto datasets suffer in quality from this approach. This is because of the massive interpolation required to fill the DSM with nearest neighbor, which creates "step ladders" that look distorted.

The current approach has distortion as well, but in lesser amounts.

I will modify the branch to retain the current approach to meshing for --fast-orthophoto.

smathermather · 2018-10-28T22:11:04Z

Yes, I wondered what the effect on fast ortho would be.

You should add the Zanzibar city example to this series is you can. It makes subtle but important differences.

smathermather · 2018-10-29T02:35:01Z

If I get a chance to add it I will, but I might need a tip on your favorite gif maker. I’d hate to include and example without that wonderful addition. :D

pierotofy · 2018-10-29T03:09:56Z

It's just GIMP.

Add both layers to QGIS
Take a full window screenshot
Paste first layer in GIMP
Toggle a layer in QGIS
Take another full window screenshot
Paste the second layer in GIMP
Crop as desired
From GIMP File --> Export As --> "filename.gif", from GIF options check "As animation", type desired delay (I use 2000, 2 seconds), then "Export".
Drag & Drop directly to GitHub issue.

pierotofy · 2018-10-29T03:45:59Z

Current master:

This branch:

More defined buildings

pierotofy · 2018-10-29T03:49:33Z

Current master:

This branch:

More defined buildings

pierotofy · 2018-10-29T03:53:27Z

Current master:

This branch:

Not much difference, perhaps better orthogonality in this branch.

pierotofy · 2018-10-29T03:59:37Z

Hoping to merge this in sometimes next week unless problems are discovered, or there's feedback of any kind to improve the code. cc @dakotabenjamin

smathermather · 2018-11-02T02:11:02Z

w00t!

Dem2mesh Former-commit-id: ee53533

pierotofy added 23 commits September 29, 2018 16:53

Started modifying dem2points to dem2mesh

7e5c6cb

dem2mesh code working

beba2c1

Renamed dem2points --> dem2mesh, MAX_INT striding, cleanup

fed76ed

maxVertexCount param fix, added dem2mesh calls, cleanup

c9e6640

Trimmed edges

d681180

Median filter nearest neighbor fill

e29091f

Improved memory usage, using vtkGreedyTerrainDecimator for 2.5D mesh …

c3aedc3

…generation

Cleanup

ab5c1cf

Restored sampling/simplifier approach to dem2mesh

8afa3e5

Simplifier cleanup, memory usage reduction

06fb266

Sub-mesh splitting working

feecd01

Striding fix

496cbf2

Water tight boundaries between tiles

f85a8c9

max threshold for simplification

65d1f6b

Disk offloading, max_threshold flag

98c340a

Merged changes

e443f9f

Optimizations, late tranform

819a7c8

Removed striding, edge merging, still some issues

9dfe925

dem2mesh quad tree merge working

cb21971

Cleanup, logger output setup

1bdc478

Tweaked DSM resolution

dc81b36

Blocks depth auto selection, DSM resolution based on GSD estimate

d0a9374

FileNotFoundError --> IOError exception bug fix

c1d75ff

pierotofy added the enhancement label Oct 19, 2018

pierotofy requested review from smathermather and dakotabenjamin October 19, 2018 22:24

pierotofy added 2 commits October 24, 2018 12:30

Moved dem2mesh in separate repository

1c75c6b

Increased version number

3d1398e

Added back poisson 2.5D meshing method for fast-orthophoto

52428f7

Fixed rerun logic for smvs

e2f4a78

pierotofy merged commit ee53533 into OpenDroneMap:master Nov 1, 2018

peddyhh pushed a commit to peddyhh/ODM that referenced this pull request Jun 7, 2020

Merge pull request OpenDroneMap#904 from pierotofy/dem2mesh

e4dfdbd

Dem2mesh Former-commit-id: ee53533

pierotofy added a commit that referenced this pull request Sep 21, 2020

Merge pull request #904 from pierotofy/dem2mesh

cc994cd

Dem2mesh Former-commit-id: ee53533

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dem2mesh #904

Dem2mesh #904

pierotofy commented Oct 19, 2018 •

edited

pierotofy commented Oct 19, 2018

smathermather commented Oct 20, 2018

smathermather commented Oct 22, 2018

smathermather commented Oct 22, 2018

smathermather commented Oct 22, 2018

pierotofy commented Oct 22, 2018

pierotofy commented Oct 28, 2018

pierotofy commented Oct 28, 2018

pierotofy commented Oct 28, 2018 •

edited

pierotofy commented Oct 28, 2018

pierotofy commented Oct 28, 2018

pierotofy commented Oct 28, 2018

pierotofy commented Oct 28, 2018

pierotofy commented Oct 28, 2018 •

edited

smathermather commented Oct 28, 2018

smathermather commented Oct 29, 2018

pierotofy commented Oct 29, 2018

pierotofy commented Oct 29, 2018

pierotofy commented Oct 29, 2018

pierotofy commented Oct 29, 2018

pierotofy commented Oct 29, 2018

smathermather commented Nov 2, 2018

Dem2mesh #904

Dem2mesh #904

Conversation

pierotofy commented Oct 19, 2018 • edited

pierotofy commented Oct 19, 2018

smathermather commented Oct 20, 2018

smathermather commented Oct 22, 2018

smathermather commented Oct 22, 2018

smathermather commented Oct 22, 2018

pierotofy commented Oct 22, 2018

pierotofy commented Oct 28, 2018

pierotofy commented Oct 28, 2018

pierotofy commented Oct 28, 2018 • edited

pierotofy commented Oct 28, 2018

pierotofy commented Oct 28, 2018

pierotofy commented Oct 28, 2018

pierotofy commented Oct 28, 2018

pierotofy commented Oct 28, 2018 • edited

smathermather commented Oct 28, 2018

smathermather commented Oct 29, 2018

pierotofy commented Oct 29, 2018

pierotofy commented Oct 29, 2018

pierotofy commented Oct 29, 2018

pierotofy commented Oct 29, 2018

pierotofy commented Oct 29, 2018

smathermather commented Nov 2, 2018

pierotofy commented Oct 19, 2018 •

edited

pierotofy commented Oct 28, 2018 •

edited

pierotofy commented Oct 28, 2018 •

edited