Reworks dt1widget makeSubtileFlags to use dropdown menu #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrucee
force-pushed
the
311_dt1-widget-dropdown
branch
from
0c1c1ff
to
088e3cc
Compare
gucio321
reviewed
Jun 8, 2021
hswidget/dt1widget/widget.go
Outdated
| @@ -579,13 +580,21 @@ func (p *widget) SetTileGroup(tileGroup int32) { | |||
| } | |||
|
|
|||
| func (p *widget) makeSubtileFlags(state *widgetState, tile *d2dt1.Tile) giu.Layout { | |||
| sf := state.subtileFlag | |||
There was a problem hiding this comment.
you don't need to do that, just use state.subtileFlag below
There was a problem hiding this comment.
True! I'll fix this. This means that the OnChange func can also be removed making the giu.Combo a single line
bbrucee
force-pushed
the
311_dt1-widget-dropdown
branch
from
088e3cc
to
28bf6c1
Compare
gucio321
reviewed
Jun 8, 2021
bbrucee
force-pushed
the
311_dt1-widget-dropdown
branch
from
28bf6c1
to
4a4e5ef
Compare
bbrucee
force-pushed
the
311_dt1-widget-dropdown
branch
from
4a4e5ef
to
8e03361
Compare
gucio321
previously approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #311
Follows style of dropdown used in the dc6 widget