New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync code from fork back to upstream #251
Open
Kyle-Ye
wants to merge
19
commits into
OpenCombine:master
Choose a base branch
from
OpenSwiftUIProject:upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial support for swift-docc documentation * Update OpenCombine.md * Remove unneccessary Swift 5.7 check code * Update CI job * Fix Swift 6 warning issue * Remove cocoapods support and update action * Fix compile issue on some Xcode version * Fix testMapKeyPathReflection test case on Swift 5.8+ * Fix PublisherConcurrencyTests case on some Swift version * Skip some tests on DispatchQueueSchedulerTests * Skip some tests on Linux platform This is failing on GitHub action but I can’t reproduce it locally on Ubuntu 22.04 + Swift 5.9.2 * Add TSAN check support and skip some tests on Linux when TSAN is enabled Compiler.h is from WebKit code See https://github.com/WebKit/WebKit/blob/57feb7424beb442bf5df7ca404f4439bbad72717/Source/WTF/wtf/Compiler.h * Update macos yml to skip release test on Xcode 14.3.1 * Skip assertCrashes on Linux + TSAN * Skip another flacky test on macOS
* Update Subscribers.Demand Align the implementation with Xcode 15 SDK Combine’s swiftinterface * Update Demand.assertNonZero * [Optimize] Align with Combine interface * Fix WASM platform build issue * Fix flacky test case on Xcode 14.3.1
* Reimplement Zip to fix reference crash issue * Add a test case for the documentation demo * Fix wasm platform build issue
* Add testEqutable to improve test covergae of Zip * Update README and remove unnessary file
* Fix flaky test on macOS * Update workflow file * Remove dynamicCast The test case will fail on macOS 13+Xcode 15.1. My macOS 14 + Xcode 15 will not fail. CI’s original macOS 12 + Xcode 14.3.1 will also not fail. * Skip assertParent on macOS 13 * Fix flaky test XCTAssertEqualWithAccuracy failed: ("724781190.522143") is not equal to ("724781190.421201") +/- ("0.1") * Update gitignore file
The check is already included by using numericCast in compare method
* Add merge implementation * Add Merge3 and MergeMany * Fix receive implementation * Fix swift-docc doc warning * Add merge test * Update RemainingCombineInterface file * Update README * Update Merge implementation to fix test case issue * Fix testNoDemandOnSubscriptionCrashes case
* Update README.md to add SPI badge * Update Package.swift * Update WASI check to os(WASI) * Fix watchOS and tvOS CI build issue
* Add library evolution support * Update doc and align with AnyPublisher with Combine’s swiftinterface
* Implement CombineLatest * Update Publishers.Zip * Update Merge * Update CombineLatest * Add CombineLatestTests * Update CombineLatest doc * Fix compile issue on Linux --------- Co-authored-by: Sergej Jaskiewicz <jaskiewiczs@icloud.com>
This was referenced Dec 28, 2023
* Update WASM CI * Update WASM CI to use multi jobs instead of matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
The branch upstream will be fork/main plus a commit for reverting back the README change and default branch name.
Future plan