New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document an expected crash #158
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 98.40% 98.37% -0.03%
==========================================
Files 84 84
Lines 4758 4744 -14
==========================================
- Hits 4682 4667 -15
- Misses 76 77 +1
Continue to review full report at Codecov.
|
LGTM Generated by 🚫 Danger Swift against a2376c8 |
The proposed new test trips TSAN on Linux with: |
Honestly, I don't think this is the right direction. This is a data race, which is undefined behavior, meaning that anything could happen and, strictly speaking, a crash is not guaranteed to occur, for example, if GCD decides to map the global queue to a single CPU core. |
@glessard I'm curious though, how did you encounter this crash? |
There should not be a data race because |
Follow-up to #157.
Adds the test with an
assertCrashes
block, to monitor if and when the official Combine stops crashing in this situation (FB7722681).Note that
Just
andOptional.Publisher
exhibit the same behaviour.