[4] Added rotate tool and selection box tool #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonMontealegre
changed the title
LeonMontealegre
changed the title
…rcuits/OpenCircuits into model_refactor_api_tools4
… as an API method on CircuitDesigner and refactored InputAdapter to be constructed instead of reset
KevinMackenzie
requested changes
Apr 16, 2023
LeonMontealegre
changed the base branch from
model_refactor_api_tools3
to
model_refactor_api
…OpenCircuits into model_refactor_api_tools4
TGCrystal
previously approved these changes
Apr 16, 2023
… simplify parts of the code
KevinMackenzie
approved these changes
Apr 16, 2023
TGCrystal
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of their implementations are copied from how they have been
Changed how InputAdapter works, so that instead of constructing it once and then setting up/tearing down on it, instead construct it to set it up and then tear it down when necessary and re-construct it to set it up again. Removes need to
!every access ofcanvasin the InputAdapter, and also removes need to have an optional instance of it inCircuitDesigner, instead it's just held locally.This does come at the cost of not having an explicit
tearDownmethod anymore onCircuitDesignerand instead needing to use the callbacktearDown.