Model refactor api expr to circ #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TGCrystal
changed the base branch from
model_refactor_api_views1
to
model_refactor_api
LeonMontealegre
requested changes
Apr 27, 2023
github-actions
bot
added
Status: Changes Requested
and removed
Status: Awaiting Review
labels
StringUtils, Formats, and DataStructures are the only things unchanged. Core algorithm files were changed to accommodate Result. |
github-actions
bot
added
Status: Awaiting Review
and removed
Status: Changes Requested
labels
src/site/pages/digital/src/utils/ExpressionParser/GenerateInputTree.ts
Outdated
Show resolved
Hide resolved
src/site/pages/digital/src/utils/ExpressionParser/GenerateInputTree.ts
Outdated
Show resolved
Hide resolved
src/site/pages/digital/src/utils/ExpressionParser/TreeToCircuit.ts
Outdated
Show resolved
Hide resolved
LeonMontealegre
requested changes
Feb 6, 2024
| @@ -0,0 +1,24 @@ | |||
| import {Graph} from "math/Graph"; | |||
There was a problem hiding this comment.
let's move this file into app/core/utils I think
src/app/tests/Extensions.ts
Outdated
| // } | ||
|
|
||
| // const pass = bfs([source], depth); | ||
| toBeOk(received: unknown) { |
There was a problem hiding this comment.
You can just say received: Result and then you don't have to type-check it, I should probably do that for the others but I was probably referencing some js
src/app/tests/Extensions.ts
Outdated
| // pass, | ||
| // }; | ||
| // }, | ||
| toIncludeError(received: unknown, message: string) { |
| @@ -0,0 +1,43 @@ | |||
| // TODO[model_refactor_api](trevor): Get this working for expression to circuit frontend | |||
There was a problem hiding this comment.
Why not get this working now ?
github-actions
bot
added
Status: Changes Requested
and removed
Status: Awaiting Review
labels
LeonMontealegre
approved these changes
Feb 6, 2024
github-actions
bot
added
Status: Ready to Merge
and removed
Status: Changes Requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1264
closes #1273
closes #1277