Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Ability to filter on representatives in streams/playbooks/triggers (#6799) #6925

Merged
merged 7 commits into from
May 24, 2024

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented May 10, 2024

Chunk 1 of issue: #6799

Chunk 1: ability to filter on representatives in streams/playbooks/triggers

(Chunk 2 later: ability to filter on representatives in feeds, taxii and entity lists)

doc PR : OpenCTI-Platform/docs#165

@Archidoit Archidoit added filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification labels May 10, 2024
@Archidoit Archidoit self-assigned this May 10, 2024
@Archidoit Archidoit changed the title [frontend/backend] Ability to filter on representatives in streams/playbooks/triggers [frontend/backend] Ability to filter on representatives in streams/playbooks/triggers (#6799) May 13, 2024
@Archidoit Archidoit force-pushed the issue/6799 branch 3 times, most recently from 89debc2 to 39147ae Compare May 13, 2024 12:01
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.59%. Comparing base (e8e8382) to head (f523555).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6925      +/-   ##
==========================================
+ Coverage   67.48%   67.59%   +0.11%     
==========================================
  Files         561      561              
  Lines       68734    68773      +39     
  Branches     5774     5843      +69     
==========================================
+ Hits        46384    46487     +103     
+ Misses      22350    22286      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit Archidoit force-pushed the issue/6799 branch 4 times, most recently from 56c81ff to 96dde48 Compare May 22, 2024 07:59
@SouadHadjiat
Copy link
Member

Not really related to this PR, but do you know why we have two methods for representative extraction : extractRepresentative (in entity-representative) and extractStixRepresentative (in stix-representative) ? what is the difference between the two ?

@Archidoit
Copy link
Member Author

@SouadHadjiat : extractStixRepresentative extracts the representative of an entity that is in the stix format, extractRepresentative extracts the representative of an entity in the BasicStoreCommon format

@SouadHadjiat
Copy link
Member

Can they return different values ? about the main representative.

@Archidoit
Copy link
Member Author

Archidoit commented May 24, 2024

@SouadHadjiat there are some differences (exemple for Attack Patterns : name in stix representative // composition of x_mitre_id and name in entity representative)

Copy link
Member

@SouadHadjiat SouadHadjiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally ✅

@Archidoit Archidoit merged commit 3eb8260 into master May 24, 2024
5 checks passed
@Archidoit Archidoit deleted the issue/6799 branch May 24, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team filters temporarily used to identify filter issue to facilitate filter team’s work identification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants