Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] e2e tests for CRUD operations on Reports (#5648) #6682

Merged
merged 6 commits into from May 2, 2024

Conversation

lndrtrbn
Copy link
Member

@lndrtrbn lndrtrbn commented Apr 12, 2024

Proposed changes

  • Start backend with e2e prefix for Elastic indices when running tests locally
  • Possibility to inject STIX data in indices
  • Page models for input fields and forms
  • e2e tests on CRUD operations for Reports

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@lndrtrbn lndrtrbn force-pushed the issue/5648 branch 2 times, most recently from 09d3a9e to deacb1c Compare April 22, 2024 13:10
@lndrtrbn lndrtrbn force-pushed the issue/5648 branch 3 times, most recently from d712474 to 9c84a3c Compare April 29, 2024 14:19
@lndrtrbn lndrtrbn changed the title Issue/5648 [frontend/backend] e2e tests for CRUD operations on Reports (#5648) Apr 29, 2024
@lndrtrbn lndrtrbn added the filigran team use to identify PR from the Filigran team label Apr 29, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.93%. Comparing base (dc3cd32) to head (4e14c2b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6682      +/-   ##
==========================================
- Coverage   67.94%   67.93%   -0.01%     
==========================================
  Files         553      553              
  Lines       67171    67171              
  Branches     5657     5656       -1     
==========================================
- Hits        45640    45635       -5     
- Misses      21531    21536       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lndrtrbn lndrtrbn marked this pull request as ready for review May 2, 2024 08:32
@lndrtrbn lndrtrbn marked this pull request as draft May 2, 2024 13:58
@lndrtrbn lndrtrbn marked this pull request as ready for review May 2, 2024 15:47
@Kedae Kedae merged commit c0e354c into master May 2, 2024
5 checks passed
@Kedae Kedae deleted the issue/5648 branch May 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants