Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] add logical delete documentation #163

Merged
merged 6 commits into from
May 28, 2024
Merged

[docs] add logical delete documentation #163

merged 6 commits into from
May 28, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented May 7, 2024 •
edited

  • Delete & restore usage page (/usage/delete-restore/)
  • Trash manager configuration
  • Update indices list
  • Update retention manager page

OpenCTI-Platform/opencti#1536

@SouadHadjiat SouadHadjiat marked this pull request as ready for review May 13, 2024 15:06
nino-filigran
nino-filigran reviewed May 20, 2024
View reviewed changes
docs/usage/delete-restore.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also explain the impact on te streams of the restore? Something like: "When restoring, it acts like a create in the platform. Therefore, your feeds will be impact following the usual creation process.
A restored item will have a specific record within its activity, called "restore"".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where to put it in the file, hence only a comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how we can explain it well, we already explain that restore is a creation :

Restoring an element creates it again in the platform with the same information it had before its deletion.

Jipegien
Jipegien reviewed May 20, 2024
View reviewed changes
Copy link
Member

@Jipegien Jipegien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some modifications to validate.

@SamuelHassine SamuelHassine merged commit 5ea37ae into main May 28, 2024
@SamuelHassine SamuelHassine deleted the opencti/1536-delete-restore branch May 28, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nino-filigran nino-filigran nino-filigran left review comments

@Jipegien Jipegien Awaiting requested review from Jipegien

Assignees
No one assigned
Labels
filigran-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SouadHadjiat @Jipegien @nino-filigran @SamuelHassine @labo-flg