Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Financial data #572

Closed
wants to merge 2 commits into from
Closed

Financial data #572

wants to merge 2 commits into from

Conversation

ParamConstructor
Copy link
Contributor

Proposed changes

This is the PYCTI changes required to support the OpenCTI PR - OpenCTI-Platform/opencti#5287

  • Add new observables: Financial Accounts, Financial Assets, and Financial Transactions
  • Add new vocabularies: financial_account_status, financial_account_type, asset_type, currency_code
  • Removed BankAccount and CryptoWallet observables (migrated to Financial Account in OpenCTI)
  • Add relation support for new observables

Related issues

  • This needs to be deployed in tandem with the OpenCTI PR
  • We have tested locally using unit tests / pytest locally - but the automated pipeline has not been used due to it checking out "master" on OpenCTI branch versus the equivalent "financial_data" branch

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

N/A

@Bonsai8863 Bonsai8863 mentioned this pull request Feb 28, 2024
Open
5 tasks
@Bonsai8863 Bonsai8863 force-pushed the financial_data branch 3 times, most recently from 13e9053 to 303c031 Compare March 4, 2024 14:52
@Bonsai8863 Bonsai8863 force-pushed the financial_data branch 2 times, most recently from df96953 to f335ef7 Compare March 11, 2024 10:37
@ParamConstructor ParamConstructor force-pushed the financial_data branch 2 times, most recently from f74645f to 9661c81 Compare April 3, 2024 15:48
@ParamConstructor ParamConstructor force-pushed the financial_data branch 2 times, most recently from fcbb5f1 to cda8f39 Compare April 8, 2024 18:54
@ParamConstructor ParamConstructor force-pushed the financial_data branch 2 times, most recently from f80b206 to f004493 Compare May 14, 2024 14:02
@aHenryJard aHenryJard added the multi-repository When a PR requires several repository changes label May 30, 2024
@ParamConstructor
Copy link
Contributor Author

Closing to update Branch name to support multi-repo CI Pipeline run. Replaced with - #667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
multi-repository When a PR requires several repository changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ParamConstructor @aHenryJard @Bonsai8863