Various minute improvements #30
Conversation
|
LGTM |
There was a problem hiding this comment.
LGTM, but next time don't forget to adjust the Copyright statement
| @@ -49,6 +49,8 @@ def flow2pwn(flow): | |||
|
|
|||
| for message in flow['flow']: | |||
| data = base64.b64decode(message["b64"]) | |||
| if finder := match(b'bd-executor: (.{50})', data): | |||
There was a problem hiding this comment.
LGTM, +1 for the 50 character limit to prevent DoS
| @@ -49,6 +49,8 @@ def flow2pwn(flow): | |||
|
|
|||
| for message in flow['flow']: | |||
| data = base64.b64decode(message["b64"]) | |||
| if finder := match(b'bd-executor: (.{50})', data): | |||
There was a problem hiding this comment.
Thank you for your first contribution!
I do feel however that your patch is lacking a little bit of documentation. Coukd you explain what bug you're trying to fix, and how you observed this bug? We at the Tulip Development Sweatshop really take feedback seriously, so unfortunately we can't accept patches that don't have any feedback attached with them.
Also, if you have the time, please take a look at #17, it looks to me like these are probably related.
Ping me once you got that covered, and I'll gladly merge!
|
Nice try ;) |
As the title states.