Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cityscape][Economy] Supplies purchased from orgs/buildings that have been destroyed give the wrong message #843

Open
FilmBoy84 opened this issue Apr 28, 2020 · 3 comments
Labels
!BUG! MEDIUM PRIORITY A serious issue! Stops game progression or loses data, but no crash. Needs a fix finding ASAP! Cityscape An issue relating to something in the City overview part of Apocalypse Help Wanted Help is required in making this fix/feature complete. If you can code or test, please take a look! Marketplace / Economy Something that affects transactions or behaviour or logic in the Marketplace or Economy screens Organisations Something that affects Organisation/Alien Behaviours Verified / Replicated This issue has been verified or replicated by a developer

Comments

@FilmBoy84
Copy link
Collaborator

Tested under EWM v9 preview 4 by Proselyte Ethan
HOWEVER
You can replicate in normal OpenApoc by doing the following

Destroy all Arms Factories/Flyers for Marsec and Megapol
Ensure you are still allied/friendly to those factions afterwards
Attempt to purchase an item that would normally come from those buildings

Even though the organisations are friendly, the game will prompt that it cannot make the delivery as the organisations are hostile - the wrong message

We need a new prompt to tell the user that the delivery cannot be made as the supplier is rebuilding the facility (we should be able to get the exact text string from OG)

Here's an example save under EWM v9 preview 4
save_Psionic_Rebalance_Playthrough.zip

Additional error message
image

@FilmBoy84 FilmBoy84 added Help Wanted Help is required in making this fix/feature complete. If you can code or test, please take a look! !BUG! MEDIUM PRIORITY A serious issue! Stops game progression or loses data, but no crash. Needs a fix finding ASAP! Verified / Replicated This issue has been verified or replicated by a developer labels Apr 28, 2020
@FilmBoy84
Copy link
Collaborator Author

One of the interesting things about that save is it shows a feature i was not aware of
Because, after a few hours, the order made cannot be delivered it expires and is refunded
We obviously do not want to lose this functionality when fixing the message
image

@FilmBoy84
Copy link
Collaborator Author

FilmBoy84 commented Apr 28, 2020

It is unclear why the buildings in that save are collapsed

Ethan reports that he was using the raids collapse buildings function, but had not raided these particular establishments in recent times - for some reason on save load it collapses them again despite them having been rebuilt since his raids

It may be worth considering that there is another issue here that savegames where buildings have been collapsed do not have the flag that it is down removed when the organisation rebuilds the facility. Thus, on loading the game, the building once more collapses.

There are also stuck vehicles at one of the arms factories

So there are a number of issues with this save

That said i have been able to replicate the order issue on Vanilla builds of OpenApoc so it is not exclusive to the EWM

@emptyVoid
Copy link
Contributor

Even though the organisations are friendly, the game will prompt that it cannot make the delivery as the organisations are hostile - the wrong message

We need a new prompt to tell the user that the delivery cannot be made as the supplier is rebuilding the facility (we should be able to get the exact text string from OG)

I don't see any problem with collapsed building in this save game (aside from trapped ground vehicles). Goods from Marsec get delivered just fine. From Megapol you just have to deliver them with your own craft, since Transtellar is hostile towards Megapol and refuses transportation services for purchases made from Megapol.

@FilmBoy84 FilmBoy84 added Marketplace / Economy Something that affects transactions or behaviour or logic in the Marketplace or Economy screens Organisations Something that affects Organisation/Alien Behaviours Cityscape An issue relating to something in the City overview part of Apocalypse labels Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!BUG! MEDIUM PRIORITY A serious issue! Stops game progression or loses data, but no crash. Needs a fix finding ASAP! Cityscape An issue relating to something in the City overview part of Apocalypse Help Wanted Help is required in making this fix/feature complete. If you can code or test, please take a look! Marketplace / Economy Something that affects transactions or behaviour or logic in the Marketplace or Economy screens Organisations Something that affects Organisation/Alien Behaviours Verified / Replicated This issue has been verified or replicated by a developer
Projects
None yet
Development

No branches or pull requests

2 participants