Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inventory Space/Template Bug #639

Closed
Quickmind01 opened this issue Jul 14, 2019 · 3 comments
Closed

Inventory Space/Template Bug #639

Quickmind01 opened this issue Jul 14, 2019 · 3 comments
Labels
!BUG! low priority This is a bug in OpenApoc. It will need resolving when time allows. It does not always cause a CTD !BUG! MEDIUM PRIORITY A serious issue! Stops game progression or loses data, but no crash. Needs a fix finding ASAP!

Comments

@Quickmind01
Copy link

Related to Issue #637 with this bug, the storage space goes to 999%+. However, when attempting to sell these toxi-gun A clips, they do not appear in the list of things to sell. This then leaves storage too full to buy, sell, or transfer anything, including aliens. Also, it appears craft can't drop aliens (and captured equipment) off at other bases before returning to their home base. This also prevents the transfer of things.

save_Inventory Space-Template Bug.zip
@makus82 makus82 added !BUG! low priority This is a bug in OpenApoc. It will need resolving when time allows. It does not always cause a CTD !BUG! HIGH PRIORITY Crashes the game! A serious issue stopping game progress or losing data. Needs a fix finding ASAP! labels Jul 20, 2019
@Quickmind01
Copy link
Author

Update: In my stream today, I learned that if I duplicate more clips, it pushes the inventory number to even more ridiculous numbers. However, this somehow allows selling and transferring to work again, though the toxi-gun A, B, and C clips are then not able to be sold from that base.

This was referenced Jul 23, 2019
Closed
Merged
@JonnyH
Copy link
Collaborator

JonnyH commented Jul 24, 2019

So I have found an issue when a template stores a weapon with more ammo than is available when applying it - it doesn't check or clamp the current value, causing an underflow in the inventory (which as it's unsigned causes it to go a /really/ high value, some 4 billion on a 32bit integer).

@JonnyH JonnyH added !BUG! MEDIUM PRIORITY A serious issue! Stops game progression or loses data, but no crash. Needs a fix finding ASAP! and removed !BUG! HIGH PRIORITY Crashes the game! A serious issue stopping game progress or losing data. Needs a fix finding ASAP! labels Jul 24, 2019
@JonnyH
Copy link
Collaborator

JonnyH commented Jul 26, 2019

Think this was fixed by #654

@JonnyH JonnyH closed this as completed Jul 26, 2019
@JonnyH JonnyH mentioned this issue Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
!BUG! low priority This is a bug in OpenApoc. It will need resolving when time allows. It does not always cause a CTD !BUG! MEDIUM PRIORITY A serious issue! Stops game progression or loses data, but no crash. Needs a fix finding ASAP!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JonnyH @makus82 @Quickmind01