Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPCRASH (all the time) #557

Closed
1CarlGauss opened this issue Apr 24, 2019 · 14 comments
Closed

APPCRASH (all the time) #557

1CarlGauss opened this issue Apr 24, 2019 · 14 comments
Labels
!BUG! HIGH PRIORITY Crashes the game! A serious issue stopping game progress or losing data. Needs a fix finding ASAP!

Comments

@1CarlGauss
Copy link

1CarlGauss commented Apr 24, 2019

Hello everyone!
Game crashes all the time randomly (not in battle mode). May happend after 10 seconds after start or just any time. I've tried last v0.1-447-g109644d5 + official gog version of the game.
Windows says (RU):
Сигнатура проблемы:
Имя события проблемы: APPCRASH
Имя приложения: OpenApoc.exe
Версия приложения: 0.0.0.0
Отметка времени приложения: 5cbe2045
Имя модуля с ошибкой: OpenApoc.exe
Версия модуля с ошибкой: 0.0.0.0
Отметка времени модуля с ошибкой: 5cbe2045
Код исключения: c0000005
Смещение исключения: 000000000009ec9b
Версия ОС: 6.1.7601.2.1.0.256.48
Код языка: 1049
Дополнительные сведения 1: 4aeb
Дополнительные сведения 2: 4aebd51fab1d00395e37b483f511b0c7
Дополнительные сведения 3: 692c
Дополнительные сведения 4: 692ccecc8f68ee8eb546f715ef6813aa

+uploading openapoc log file
Using Win 7 x64
Thx!
openapoc_log.txt

@KometFox
Copy link

Looks like your XCOM.BIN got corrupted somehow it should be around 604,8 MB (604.847.376 Bytes) big. Looking through your log there is plenty of corrupted files such as

I 1256638574 class std::shared_ptr<class OpenApoc::Image> __cdecl `anonymous-namespace'::LodepngImageLoader::loadImage(class OpenApoc::IFile &): Failed to read PNG headers from "C:\Games\cd.iso/xcom3/ufodata/titles.pcx" (28) : incorrect PNG signature, it's no PNG or corrupted

and

I 6111030396 class OpenApoc::IFile __cdecl OpenApoc::FileSystem::open(const class OpenApoc::UString &): Loading "xcom3/ufodata/vstrfire.pcx" from "C:\Games\cd.iso/xcom3/ufodata/vstrfire.pcx"
I 6112258526 class std::shared_ptr<class OpenApoc::Image> __cdecl `anonymous-namespace'::LodepngImageLoader::loadImage(class OpenApoc::IFile &): Failed to read PNG headers from "C:\Games\cd.iso/xcom3/ufodata/vstrfire.pcx" (28) : incorrect PNG signature, it's no PNG or corrupted

The log outputs that 50x times from different files.

@JonnyH
Copy link
Collaborator

JonnyH commented Apr 25, 2019

Those PNG "errors" are normal - it tries to see if an image file is a PNG file (which they aren't), then it falls back to PCX (which those files are). So only if you see the PCX loader failing should that actually be an error.

@1CarlGauss
Copy link
Author

I've tied 2 versions of the game and same story happends still, don't know what to do.

@JonnyH
Copy link
Collaborator

JonnyH commented Apr 25, 2019

I haven't seen this issue myself - maybe there's something different with your system (OS/driver versions, settings like localisation?)

Is there any chance you can get a backtrace? It might help us figure out what's going on if we know exactly where it's crashing.

@KometFox
Copy link

Those PNG "errors" are normal - it tries to see if an image file is a PNG file (which they aren't), then it falls back to PCX

I thought it was suspicious that it could cause for him the crash as my log doesn't mention it tried to load pcx file as png. At the end of file it doesn't show any warning or errors at all which provoked this crash.

May happend after 10 seconds after start or just any time.

Do you have any guesses how long it takes for a crash to happen? Also can you recall what were you trying to do just before the crash happened?

@1CarlGauss
Copy link
Author

1CarlGauss commented Apr 25, 2019

  1. I'll try to get backtrace tommorow and update info (never did it before).
  2. No guesses at all. Last time crash happened, it was the first day start time (I thought the problem might be in renaming agents - I usually rename agents as tank 1, tank 2 and so on... but this time I have not starting renaming yet).
  3. Using EN(GB) localisation.

@1CarlGauss
Copy link
Author

Hello!
Looks like I have no skills to get a backtrace... If someone is abe to spend some time to find out what's wrong here, we can connect using TeamViewer... I'm online now in:
discord https://discord.gg/sYnshc
skype - khlopkov1 (Petr Khlopkov)
signal/what's up/viber/telegram +79639119870

@Atrosha
Copy link
Contributor

Atrosha commented Apr 25, 2019

I take him. Guide to work.

@FilmBoy84 FilmBoy84 added the !BUG! HIGH PRIORITY Crashes the game! A serious issue stopping game progress or losing data. Needs a fix finding ASAP! label Apr 26, 2019
@1CarlGauss
Copy link
Author

1CarlGauss commented Apr 26, 2019

Hello again!
We've connected with @Atrosha and using TeamViewer we've found this:
Game starts, shows intro movie and after start campain mode it shows error message dialogs:
1
2

After that game crashes and rises multiple exeptions:
3

I attach stacktrace and gamelogs:
stacktrace.txt
openapoc_log.txt

We've tried to compile latest master branch with GOG and Steam cd.iso. This backtrace for Steam CD.
GOG version works ok (1 day gameplay passed with no crashes), but before we did all that, when i installed v0.1-447-g109644d5(or just unzip it) game was crashing all the time still.

After all I've tried v0.1-447-g109644d5 + Steam version and no crashes after 5 min gameplay (miracle? moon phase?).
What changed? Well, we've installed Visual Studio and I've installed c++ packages:
4
Before it, i was trying to play using c++ packs 2015 and 2010+- (unable to say for true - don't remember).

I'll continue test tommorow and update info.

@JonnyH
Copy link
Collaborator

JonnyH commented Apr 26, 2019

Is there a "gamestate_common" in the data/ directory?

Are you running it through MSVC? Currently it expects the data directory to be in "./data", which is correct is MSVC runs it as it sets the current working directory to the root of the repository - but if you run it manually (or MSVC's run thing is different on different versions/platforms) it might be that?

Have the extractors run as part of the build? Are there difficulty1_patched and similar in the data directory?

@1CarlGauss
Copy link
Author

1CarlGauss commented Apr 26, 2019

Is there a "gamestate_common" in the data/ directory?

267 087 bytes

Are you running it through MSVC? Currently it expects the data directory to be in "./data", which is correct is MSVC runs it as it sets the current working directory to the root of the repository - but if you run it manually (or MSVC's run thing is different on different versions/platforms) it might be that?

Two build was run from MSVC. One with Steam CD, second with GOG CD.

Have the extractors run as part of the build? Are there difficulty1_patched and similar in the data directory?

difficulty1_patched size is 139 432 bytes and others are present.

@JonnyH
Copy link
Collaborator

JonnyH commented Apr 27, 2019

I added more info logs in PR #560 to help with seeing what's going on here.

Any chance you can run that and re-paste the log?

@Atrosha
Copy link
Contributor

Atrosha commented May 1, 2019

Not so fast.
For now all seems to be ok, but in the past all also was fine, and crashes starts after day of normal gameplay.

imho this is pc config errors.

@FilmBoy84
Copy link
Collaborator

This does indeed appear to be PC config dependant
We have the launcher now to assist in pointing directly to the data directory (and thus gamestate_common)
We can also specify the location of the CD.ISO/CUE/BIN

Closing as we have had no similar reports in 2 years!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!BUG! HIGH PRIORITY Crashes the game! A serious issue stopping game progress or losing data. Needs a fix finding ASAP!
Projects
None yet
Development

No branches or pull requests

5 participants