Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTD: transfering engineers #505

Open
BeornTB opened this issue Jan 25, 2019 · 17 comments
Open

CTD: transfering engineers #505

BeornTB opened this issue Jan 25, 2019 · 17 comments
Labels
Agent ID Error A label for tracking all issues relating to this long standing Agents/Scientists related crash !BUG! HIGH PRIORITY Crashes the game! A serious issue stopping game progress or losing data. Needs a fix finding ASAP! Cityscape An issue relating to something in the City overview part of Apocalypse Marketplace / Economy Something that affects transactions or behaviour or logic in the Marketplace or Economy screens Research / Scientists Something relating to research and / or scientists Verified / Replicated This issue has been verified or replicated by a developer

Comments

@BeornTB
Copy link

BeornTB commented Jan 25, 2019 •
edited

All transfering personel was unassigned to begin with.

345 CTD engineer transfer.zip

Soldiers were transfered without problems earlier on, so it seems to be about scientists. Possibly related to #482
@FilmBoy84 FilmBoy84 added !BUG! low priority This is a bug in OpenApoc. It will need resolving when time allows. It does not always cause a CTD !BUG! HIGH PRIORITY Crashes the game! A serious issue stopping game progress or losing data. Needs a fix finding ASAP! labels Jan 25, 2019
@BeornTB
Copy link
Author

BeornTB commented Jan 25, 2019

Selling/buying from one to the other works but they stay assigned and their proficiency keeps counting.

https://i.imgur.com/N6e2h6t.png

@Jarskih
Copy link
Contributor

Jarskih commented Jan 27, 2019

Did you start new game? The fix to scientist bug only works for the new saves.

@BeornTB
Copy link
Author

BeornTB commented Jan 27, 2019

Yes, brand new game with the OpenApoc-x64-v0.1-345-gea6033fa build, which I took as the "stable" 345 master build.

@Jarskih
Copy link
Contributor

Jarskih commented Jan 28, 2019

Ok I will take a look.

@FilmBoy84
Copy link
Collaborator

Another example of this bug
image

Savegame Attached
(May need old weapons mod from the discord modding channel)
save_Medium Test 06-02-19 1.zip

@FranciscoDA FranciscoDA mentioned this issue Mar 15, 2019
Closed
@FilmBoy84
Copy link
Collaborator

Please see also issue #532 which is a duplicate

@Dago73
Copy link

Dago73 commented Mar 15, 2019

saves.zip
Here my last 3 saves to debug

@Atrosha
Copy link
Contributor

Atrosha commented Mar 15, 2019 •
edited

#532 (comment)

gdb log and stack trace for 1 of #532 issue

532_1_gdb_log_n_stack_trace.txt

@Atrosha
Copy link
Contributor

Atrosha commented Mar 15, 2019

Also there is no crash on case 2. It's just shows MessageDialog with "Alien Containment exeeded"

@FilmBoy84
Copy link
Collaborator

Ah, the alien containment issue is good old #369 i'll reference this there too
Thanks for the report <3

@FilmBoy84 FilmBoy84 mentioned this issue Mar 15, 2019
Closed
@FilmBoy84
Copy link
Collaborator

See also #370

@Atrosha
Copy link
Contributor

Atrosha commented Mar 15, 2019

stack trace for case 3

532_3_gdb_log_n_stack_trace.txt

@Dago73
Copy link

Dago73 commented Mar 15, 2019

Here a screen shot
grafik
Left is Biochemie with 9 scientist. Every time i klick on the Lab, i get the message you can see.

@Atrosha
Copy link
Contributor

Atrosha commented Mar 15, 2019

After a lot of smth like that message dialogs game crashes.

@JonnyH
Copy link
Collaborator

JonnyH commented Apr 25, 2019

I think what's happening here is when transferring or selling scientists it's not disassociating them from any lab they're currently working in, so the lab holds a reference to that agent.

And nearly always you get a missing ID error, it'll crash directly afterwards - as it'll return a null object - so unless the code then doesn't use the object at all (in which case why is it bothering to look it up?) it'll deference that null pointer.

@Atrosha Atrosha mentioned this issue Jun 19, 2019
Open
@FilmBoy84 FilmBoy84 removed the !BUG! low priority This is a bug in OpenApoc. It will need resolving when time allows. It does not always cause a CTD label Jul 27, 2019
@FilmBoy84 FilmBoy84 mentioned this issue Aug 1, 2019
Open
@FilmBoy84 FilmBoy84 mentioned this issue Aug 13, 2019
Closed
@FilmBoy84
Copy link
Collaborator

FilmBoy84 commented Aug 15, 2019 •
edited

@JonnyH another instance of this bug
Here's the crash dump
Created when trying to transfer a skill 100 engineer from Base 1 to Base 2

save_Expanded Weapons Test 1.zip

OpenApoc.exe.10340.dmp.zip

To run the savegame, you will need V3 of the weapons mod
XCOM UFO TFTD Weapons Mod - Voiddweller and FilmBoy84 v3.zip

@emptyVoid
Copy link
Contributor

Cannot reproduce -- should be fixed by #720.

@FilmBoy84 FilmBoy84 mentioned this issue May 2, 2020
Closed
@FilmBoy84 FilmBoy84 mentioned this issue Oct 26, 2021
Closed
@FilmBoy84 FilmBoy84 added Agent ID Error A label for tracking all issues relating to this long standing Agents/Scientists related crash Cityscape An issue relating to something in the City overview part of Apocalypse Marketplace / Economy Something that affects transactions or behaviour or logic in the Marketplace or Economy screens labels Oct 27, 2021
@FilmBoy84 FilmBoy84 added Research / Scientists Something relating to research and / or scientists Verified / Replicated This issue has been verified or replicated by a developer labels Oct 27, 2021
@BeornTB BeornTB mentioned this issue Dec 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Agent ID Error A label for tracking all issues relating to this long standing Agents/Scientists related crash !BUG! HIGH PRIORITY Crashes the game! A serious issue stopping game progress or losing data. Needs a fix finding ASAP! Cityscape An issue relating to something in the City overview part of Apocalypse Marketplace / Economy Something that affects transactions or behaviour or logic in the Marketplace or Economy screens Research / Scientists Something relating to research and / or scientists Verified / Replicated This issue has been verified or replicated by a developer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@JonnyH @Jarskih @emptyVoid @FilmBoy84 @Atrosha @BeornTB @Dago73