New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No vehicle matching ID "VEHICLE_794" CTD #260
Comments
Just a heads up |
That backtrace looks incorrect, like it can't find the debug symbols (so it's just using the closest symbol it can find, which happens to be physfs). If you're using the appveyor builds - can you extract the 'debug' package over the top? So the .pdb files are in the same directory as the .exe? And "try to limp along" simply won't work for some errors (like this), as the error is effectively saying "We're just about to crash, and here is why:", so trying to continue just crashes :) As a longer term goal, it may be possible to dump the current 'save' state on error, it might give us useful info about what's wrong... But that may fall into exactly the same problem (if the internal data can't be trusted, we may just crash trying to write the save) |
@JonnyH No problem, will aim to get on testing with the debug package over the top when i get back from work on Monday... Currently up to my eyeballs in young Gymnasts :D |
how young? ) hope its legal XD |
@makus82 sadly, this weekend and last all but the last few were too young. But uni events when i do them are always fun - hot women, all legal 💃 As to the CTD, please find log, save, etc. attached. Just start time and the game will crash... I've done as @JonnyH said and put the debug install over things before generating these... |
And a different variation on the same save file... |
I can provide some details.
|
Ah, yes, in all games where i get this CTD i sell my wolfhound APC and Stormdog to get a few extra thousand in cash for vehicles i never use. Ill do a test on a game when i DONT sell any vehicles and see if this error occurs. |
Same problem here.... i can't selling veicle and debug option going me to desktop... |
The code of the transaction screen looks like a mess. Hard to fix this issue without refactoring. |
Did you load a game or started a new one? |
Just started a fresh game on a fresh install to check. Will confirm if still a problem. |
OK, game crashed apparently due to issue #255 before i can confirm this issue is fixed. That said, i was able to sell Stormdog and Wolfhound APC and no 794 CTD yet but also haven't got through to the end of the first day without game breaking :( Please see most recent comment on #255 for the log and screens of the crash that ended my new game |
@redv The vehicle crash seems fixed, however, the problem seems to have extended to Agents too, this bug still occurs... |
Is it crash when quit game? |
It happens when quitting the game OR entering the Base screen (case above was quitting) |
@redv Sadly i've just had the Agent 45 error again on a fresh, clean install, and new game of OpenApoc. Occured on quitting the game as follows... Game version is latest build (0.1-172 at time of writing) |
When application destruct the GameState class, firstly destroys the agents list, secondly bases, facilities, labs etc. The Lab class contains own agents list (scientists), but agents classes already destroyed. Thus the bug happens. |
@redv This time i am moving agents (on foot through the people tubes) to an alien incident in the slums. I'm also preparing to raid a CoS temple, the error occurs with the building and agents selected. |
Attach please the last save before CTD. |
@redv here you go. To repeat the error, send the Valkyrie to the CoS temple just NE of the base and send the two android agents off to the slums incident that appears after a minute or two ON FOOT. Error occurs when the Valkyrie arrives at CoS temple and you select the agents within to raid the building. Savegame was a new one created today on a clean install of OpenApoc. The game is in its first few minutes of play... |
The bug happens when the game tries to load resources for the battlemap. The map contains several blocks which selects randomly from a set. Looks like one of them leads to bug during resource loading.
The AGENT_35 is the quantum phisist Peter Jones.
|
Thanks redv ; let me know when you have an idea of what solution may work As to maps, could this be related to issue #284 ? I notice quite a number of CoS maps and a few others seem to generate errors when items are dropped by killed/stunned/panic units. |
Equipment this time :( |
Confirming this is still an issue, selling any vehicle causes this to pop up when anything associated with it gets called.
|
Several days of extensive play-testing, and I've not seen this bug since Many thanks Jarskih, RedV and JonnyH |
Bug still active July 2019. Restore saved game and then continue. Immediate error. Close the error window and it repeats. |
This error will persist in saves - so if the original cause of a bad StateRef has already happened, and you save, it'll embed that "badness" in the save, so it may not be surprising that reloading a "broken" save will cause the same error. The error message above is shown when the game tries to use that "broken" object and realises something's wrong, not an error in itself. The failure may have happened some time ago, just the broken object not yet used. So if you're testing this with the same save and haven't created a new game since the fix it likely doesn't tell us much. |
Yes, the previous 3 saves also bug out. I can go back to earlier saves if it will help. |
From the Log following a CTD...
W 52740355833 bool __cdecl OpenApoc::Vehicle::popFinishedMissions(class OpenApoc::GameState &): No next vehicle mission, going idle
E 52741482678 class std::shared_ptr __cdecl OpenApoc::Vehicle::get(const class OpenApoc::GameState &,const class OpenApoc::UString &): No vehicle matching ID "VEHICLE_794"
0x00000001402F9D30 PHYSFS_writeSLE16+0x15f400
0x000000014020208A PHYSFS_writeSLE16+0x6775a
0x00000001401FFD3A PHYSFS_writeSLE16+0x6540a
0x00000001400A784C PHYSFS_swapULE64+0x6600c
0x000000013FFA3D32 PHYSFS_swapULE64+0xfffffffffff624f2
0x000000013FF7F210 PHYSFS_swapULE64+0xfffffffffff3d9d0
0x000000014017E015 PHYSFS_swapULE64+0x13c7d5
0x0000000077A159CD BaseThreadInitThunk+0xd
0x0000000077C4A561 RtlUserThreadStart+0x21
The text was updated successfully, but these errors were encountered: