Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenApoc differs vehicle numbering from Original Game, there should be an optional feature to mimic OG where possible #1404

Open
ayrtondenner opened this issue Apr 13, 2024 · 8 comments
Labels
Enhancement This is a request for something that makes OpenApoc work better or more intuitively Feature Request This is a request for a new thing to be added to OpenApoc Quality of Life (QoL) A feature or change that makes playing the game more streamlined Roadmap A an issue containing features that need to be completed for a "full" gaming experience. Verified / Replicated This issue has been verified or replicated by a developer

Comments

@ayrtondenner
Copy link
Contributor

Describe the bug
When buying a new Valkyrie Interceptor, instead of using previous number plus 1, it is being assigned number 91

To Reproduce

  1. Check number assigned to previous vehicle
  2. Buy a new vehicle
  3. Check wrong assigned number

Expected behavior
It should be assigned number of previous vehicle plus 1

Savegame
test vehicle wrong number.zip

Screenshots
image

@FilmBoy84
Copy link
Collaborator

See also #1312

There is a reason why OpenApoc chose to randomly assign numbers - I cannot recall what it was

But there should certainly be an option to mimic OG behaviour as standard

@ayrtondenner
Copy link
Contributor Author

Yep, I saw the comment made in that task, but I understand that they are different issues, so for me it makes sense to have this separated issue here.

@Kurtsley
Copy link
Contributor

You original Valkyrie interceptor is part of the initial vehicles assigned to orgs when the game starts. These are always going to be the first vehicles assigned or purchased in the city so they will always be the lowest number. When you buy the next Valkyrie, it is after all other orgs have been assigned their own vehicles. This next Valkyrie will be assigned 91 because it is literally the 91st in the city. This is why #1312 needs to be implemented, to separate the XCOM vehicles from the rest of the city.

@Kurtsley
Copy link
Contributor

If you buy more than one Valkyrie, they will correctly increment by one ex: 91, 92, 93.

@ayrtondenner
Copy link
Contributor Author

Can the game create more vehicles? So after I buy Valkyrie 91, then the game creates more vehicles, so my next purchase will be assigned 101 for instance. Is that possible in current state?

@Kurtsley
Copy link
Contributor

If you buy the vehicles when the game is paused, they will increment by one up to 9999 in theory although I'm not sure on the max number. The reason it jumps to 91 is due to other orgs initial vehicles being assigned. I don't know if orgs can replace lost vehicles, maybe someone else can answer that.

@XCOM-HUB
Copy link

This is not only an issue with the Valkyrie Interceptor, but all vehicles you purchase. As others have mentioned in issue #1312, it is because OpenApoc counts all other vehicles used by different organizations. I am in favor of a prefix attached to the name of vehicles not owned by X-COM so that the number of all purchased vehicles will always be incremented by one as it is in the original game. I am also in favor of an extra "bonus" feature that would make it possible to change the color of your vehicles so it would be easier to differentiate between X-Com vehicles and other organizations' vehicles. 🚗 As I have mentioned in #774

@FilmBoy84 FilmBoy84 changed the title New Valkyrie Interceptor being assigned wrong number OpenApoc differs vehicle numbering from Original Game, there should be an optional feature to mimic OG where possible May 7, 2024
@FilmBoy84 FilmBoy84 added Enhancement This is a request for something that makes OpenApoc work better or more intuitively Feature Request This is a request for a new thing to be added to OpenApoc Verified / Replicated This issue has been verified or replicated by a developer Quality of Life (QoL) A feature or change that makes playing the game more streamlined Roadmap A an issue containing features that need to be completed for a "full" gaming experience. labels May 7, 2024
@FilmBoy84
Copy link
Collaborator

I don't know if orgs can replace lost vehicles, maybe someone else can answer that.

They can in the OG and indeed this affects both marketplace availability and organisation finances IIRC

A viable strategy to bankrupt an org in the OG without destroying their buildings is to lure out craft with attacks on buildings that do not destroy the tile then down the craft the org will then attempt to purchase more (dependent on relations and finances) and you can whittle down their money over time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This is a request for something that makes OpenApoc work better or more intuitively Feature Request This is a request for a new thing to be added to OpenApoc Quality of Life (QoL) A feature or change that makes playing the game more streamlined Roadmap A an issue containing features that need to be completed for a "full" gaming experience. Verified / Replicated This issue has been verified or replicated by a developer
Projects
None yet
Development

No branches or pull requests

4 participants