Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format credit label value #1380

Open
ayrtondenner opened this issue Mar 21, 2024 · 5 comments · May be fixed by #1467
Open

Format credit label value #1380

ayrtondenner opened this issue Mar 21, 2024 · 5 comments · May be fixed by #1467
Labels
Enhancement This is a request for something that makes OpenApoc work better or more intuitively Feature Request This is a request for a new thing to be added to OpenApoc Graphical User Interface (UI/GUI) A ticket that relates to how the user interacts with the game through the UI Marketplace / Economy Something that affects transactions or behaviour or logic in the Marketplace or Economy screens Quality of Life (QoL) A feature or change that makes playing the game more streamlined Translations / Language / Text Something that relates to the way languages, numbers or text are handled in the game

Comments

@ayrtondenner
Copy link
Contributor

ayrtondenner commented Mar 21, 2024

Right now, credit labels are presented without being formatted:
credit

We could update the value to $356.161 for better readability

@ayrtondenner ayrtondenner added the Feature Request This is a request for a new thing to be added to OpenApoc label Mar 21, 2024
@FilmBoy84 FilmBoy84 added Enhancement This is a request for something that makes OpenApoc work better or more intuitively Quality of Life (QoL) A feature or change that makes playing the game more streamlined Graphical User Interface (UI/GUI) A ticket that relates to how the user interacts with the game through the UI Marketplace / Economy Something that affects transactions or behaviour or logic in the Marketplace or Economy screens Translations / Language / Text Something that relates to the way languages, numbers or text are handled in the game labels Mar 21, 2024
@Kurtsley
Copy link
Contributor

Could this be worked into the translation somehow? I know different parts of the world use different separators eg in US $356,161.

@JonnyH
Copy link
Collaborator

JonnyH commented Mar 22, 2024

The "localization" stuff currently was really a proof of concept and known not to be particularly fit and likely significantly reworked. One thing would be the localized formatting of numbers.

I think going too deep before that rework may not be too useful.

@ayrtondenner
Copy link
Contributor Author

Could this be worked into the translation somehow? I know different parts of the world use different separators eg in US $356,161.

Yep, like English speakers usually format numbers with comma (eg $356,161) while in Portuguese we use points instead (eg $356.161)

@BeornTB
Copy link

BeornTB commented Mar 30, 2024

Same difference in French, and it makes Excel sheet databases a hot mess. Best avoid localizing it, but I do approve making a clear separation, be it with comma, period or spacing.

@JonnyH
Copy link
Collaborator

JonnyH commented Mar 30, 2024

There's a fair chunk of localization things that we need to fix that just aren't supported by the current system, what I can remember off the top of my head

  • Number formatting
  • Pluralization differences
  • Sentence order and structure (e.g. many places construct strings in a fixed order, which can be incorrect in different languages)
  • How to translate strings from mods
  • Extracting translation strings from Form files
  • How to deal with "missing" characters - the current apoc font files have a rather limited set of hand-drawn characters, so currently would require a new font set if a new character is used in a translation. But we could have a "fallback", might look ugly but still readable would probably be the goal.

Fixing these requires a fair rework, which would likely come easier after the Big String Formatting change I keep talking about but never finishing :P

There's some "features" of i18n that I don't think will be changed for apoc, though, as the "game world" isn't localized - I probably should put it up for comment to make sure I'm not ignoring something big due to my immersion into the Anglosphere, but I don't expect to need:

  • Currency formatting (it's "magic space bucks")
  • Different calendars (The "lore" I think says it's based in Future Canada, and really long-term date differences aren't a big deal in the game)
  • (Unicode encoding specific) Support for non-normalized strings - e.g. there can be multiple ways of constructing a modified/accented character, either a direct encoding of the already-accented-character, or a character followed by (maybe multiple) "accent" modifier. The second form won't work right with the current font system, and I don't think there's (many? Any?) languages that require this to be legible, but might put limits on the translated strings to avoid those situations.

So yeah, I'm not sure where I was going with this, but maybe I just wanted to say there are "known" missing features that are (slowly) being worked on. And I probably need feedback from native-level speakers of various languages to make sure I'm not missing something important from my lists above. Maybe there should be a "I18N Rework" mega-issue to keep track of all this sort of stuff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This is a request for something that makes OpenApoc work better or more intuitively Feature Request This is a request for a new thing to be added to OpenApoc Graphical User Interface (UI/GUI) A ticket that relates to how the user interacts with the game through the UI Marketplace / Economy Something that affects transactions or behaviour or logic in the Marketplace or Economy screens Quality of Life (QoL) A feature or change that makes playing the game more streamlined Translations / Language / Text Something that relates to the way languages, numbers or text are handled in the game
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants