Make it easier to get started with OpenAMP #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the "View on Github" link in jumbotron to point to the OpenAMP organization, instead of just the library.
Added Getting Started section to footer that points to documentation, demos, mailing list, and Discord.
Added social media icons that point to our GitHub, LinkedIn, and YouTube.
wmamills
reviewed
Jul 13, 2023
There was a problem hiding this comment.
My only question is about the discord link. I don't know what that looks like if you don't have discord running and not already a member of the channel & server.
I presume the user can exit w/o doing anything. I tried to test in incognito but it still redirected to me local discord app.
I presume this is OK as is.
|
Ok I tested the discord link using a dummy Linux account. It is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the suggestions in issue #97 and also fix the jumbotron button to point to the GitHub organization instead of just the OpenAMP library.