rpmsg_virtio: Move get RX buffer into receive loop and returned buffer kick to common location #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnmysh
reviewed
May 3, 2024
|
Okay, the bug fix I have in mind has a few more dependencies so for now I'll remove that part of the commit message. The patch should stand on its own just the same. |
After returning a buffer we kick the other side. This is done after both call sites of the function that returns the buffer. Move this kick call into that function to reduce code duplication and prevent it from not being done after returning the buffer. Signed-off-by: Andrew Davis <afd@ti.com>
This allows us to only need to call rpmsg_virtio_get_rx_buffer() once at the start of the loop and is easier to comprehend. Signed-off-by: Andrew Davis <afd@ti.com>
arnopo
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.